From: Nicholas Piggin <npiggin@gmail.com>
To: Balbir Singh <bsingharora@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
Vaidyanathan S <svaidy@linux.vnet.ibm.com>
Subject: Re: [PATCH] Make system_reset_pSeries relocatable
Date: Wed, 27 Jul 2016 21:51:15 +1000 [thread overview]
Message-ID: <20160727215115.166b1c72@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <CAKTCnz=YD_mf_c45_fWzjgaaVg+tC98LAxAr4Wu8FWr7At8BRQ@mail.gmail.com>
On Wed, 27 Jul 2016 20:01:24 +1000
Balbir Singh <bsingharora@gmail.com> wrote:
> On Wed, Jul 27, 2016 at 7:53 PM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> > On Wed, 2016-07-27 at 17:32 +1000, Balbir Singh wrote:
> >> From: Balbir Singh <bsingharora@gmail.com>
> >>
> >> Currently the power management bits are broken w.r.t. relocation.
> >> There are direct branches from system_reset_pSeries to
> >> power7_wakeup_*.
> >
> > Side track: we should really get rid of the _pSeries suffix for
> > these things :-)
> >
>
> I thought about it, but then thought it would need more auditing
> across places and hence held back. I'll be happy to send another patch
> to remove _pSeries from the exception-64s.S to begin with as a follow
> up
Ahh, my patches do that actually. Not as a primary concern, but
I removed almost all labels and naming from the exception-64s.h file,
and moved them into new head-64.h, so I changed the names a little
in the process.
It would be helpful to not touching this too much before we have some
more discussion of my reworking. I'm happy to rebase my stuff on top of
bugfixes though, of course.
Thanks,
Nick
next prev parent reply other threads:[~2016-07-27 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 7:32 [PATCH] Make system_reset_pSeries relocatable Balbir Singh
2016-07-27 9:53 ` Benjamin Herrenschmidt
2016-07-27 10:01 ` Balbir Singh
2016-07-27 11:51 ` Nicholas Piggin [this message]
2016-07-27 10:12 ` kbuild test robot
2016-07-27 11:34 ` Balbir Singh
2016-07-27 11:50 ` Nicholas Piggin
2016-07-27 13:57 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727215115.166b1c72@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).