From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rztcW5glDzDrLL for ; Wed, 27 Jul 2016 21:51:23 +1000 (AEST) Received: by mail-pf0-x244.google.com with SMTP id g202so1749984pfb.1 for ; Wed, 27 Jul 2016 04:51:23 -0700 (PDT) Date: Wed, 27 Jul 2016 21:51:15 +1000 From: Nicholas Piggin To: Balbir Singh Cc: Benjamin Herrenschmidt , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , Michael Ellerman , Paul Mackerras , Vaidyanathan S Subject: Re: [PATCH] Make system_reset_pSeries relocatable Message-ID: <20160727215115.166b1c72@roar.ozlabs.ibm.com> In-Reply-To: References: <48aad8b6-a27f-44c5-2b0b-f276595e9c04@gmail.com> <1469613238.5978.144.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 27 Jul 2016 20:01:24 +1000 Balbir Singh wrote: > On Wed, Jul 27, 2016 at 7:53 PM, Benjamin Herrenschmidt > wrote: > > On Wed, 2016-07-27 at 17:32 +1000, Balbir Singh wrote: > >> From: Balbir Singh > >> > >> Currently the power management bits are broken w.r.t. relocation. > >> There are direct branches from system_reset_pSeries to > >> power7_wakeup_*. > > > > Side track: we should really get rid of the _pSeries suffix for > > these things :-) > > > > I thought about it, but then thought it would need more auditing > across places and hence held back. I'll be happy to send another patch > to remove _pSeries from the exception-64s.S to begin with as a follow > up Ahh, my patches do that actually. Not as a primary concern, but I removed almost all labels and naming from the exception-64s.h file, and moved them into new head-64.h, so I changed the names a little in the process. It would be helpful to not touching this too much before we have some more discussion of my reworking. I'm happy to rebase my stuff on top of bugfixes though, of course. Thanks, Nick