From: Jack Miller <jack@codezen.org>
To: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org
Cc: jk@ozlabs.org, stewart@linux.vnet.ibm.com, benh@kernel.crashing.org
Subject: Re: [PATCH] powernv: Search for new flash DT node location
Date: Wed, 3 Aug 2016 11:44:11 -0500 [thread overview]
Message-ID: <20160803164412.7039-1-jack@codezen.org> (raw)
In-Reply-To: <147020859492.19099.3536038186529840354@concordia>
On Wed, Aug 03, 2016 at 05:16:34PM +1000, Michael Ellerman wrote:
> We could instead just search for all nodes that are compatible with
> "ibm,opal-flash". We do that for i2c, see opal_i2c_create_devs().
>
> Is there a particular reason not to do that?
I'm actually surprised that this is preferred. Jeremy mentioned something
similar, but I guess I just don't like the idea of finding devices in weird
places in the tree. Then again, if we can't trust the DT we're in bigger
trouble than erroneous flash nodes =).
If we really just want to find compatible nodes anywhere, let's simplify i2c
and pdev_init into one function and make that behavior consistent with this
new patch.
- Jack
next prev parent reply other threads:[~2016-08-03 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 20:50 [PATCH] powernv: Search for new flash DT node location Jack Miller
2016-08-01 21:04 ` Jack Miller
2016-08-03 7:16 ` Michael Ellerman
2016-08-03 16:44 ` Jack Miller [this message]
2016-08-03 16:44 ` [PATCH] powernv: Simplify searching for compatible device nodes Jack Miller
2016-08-03 17:18 ` [PATCH v2] " Jack Miller
2016-08-04 7:27 ` Cyril Bur
2016-08-04 8:39 ` Michael Ellerman
2016-08-04 16:03 ` Jack Miller
2016-08-04 3:28 ` [PATCH] powernv: Search for new flash DT node location Michael Ellerman
2016-09-27 4:44 ` Stewart Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803164412.7039-1-jack@codezen.org \
--to=jack@codezen.org \
--cc=benh@kernel.crashing.org \
--cc=jk@ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).