linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: herbert@gondor.apana.org.au, <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC
Date: Thu, 4 Aug 2016 15:00:48 +1000	[thread overview]
Message-ID: <20160804150048.005f5c02@kryten> (raw)
In-Reply-To: <1470048886-8899-1-git-send-email-mpe@ellerman.id.au>

Hi Michael,

> The optimised crc32c implementation depends on VMX (aka. Altivec)
> instructions, so the kernel must be built with Altivec support in
> order for the crc32c code to build.

Thanks for that, looks good.

Acked-by: Anton Blanchard <anton@samba.org>

> Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  crypto/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index a9377bef25e3..84d71482bf08 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -439,7 +439,7 @@ config CRYPTO_CRC32C_INTEL
>  
>  config CRYPT_CRC32C_VPMSUM
>  	tristate "CRC32c CRC algorithm (powerpc64)"
> -	depends on PPC64
> +	depends on PPC64 && ALTIVEC
>  	select CRYPTO_HASH
>  	select CRC32
>  	help

  reply	other threads:[~2016-08-04  5:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 10:54 [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC Michael Ellerman
2016-08-04  5:00 ` Anton Blanchard [this message]
2016-08-05  3:28   ` Michael Ellerman
2016-08-08 15:24     ` Herbert Xu
2016-08-08 22:46       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160804150048.005f5c02@kryten \
    --to=anton@samba.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).