From: Jack Miller <jack@codezen.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Cyril Bur <cyrilbur@gmail.com>,
linuxppc-dev@lists.ozlabs.org, stewart@linux.vnet.ibm.com,
jk@ozlabs.org
Subject: Re: [PATCH v2] powernv: Simplify searching for compatible device nodes
Date: Thu, 4 Aug 2016 11:03:12 -0500 [thread overview]
Message-ID: <20160804160312.GA30161@hypothesis> (raw)
In-Reply-To: <87k2fxexmr.fsf@concordia.ellerman.id.au>
On Thu, Aug 04, 2016 at 06:39:24PM +1000, Michael Ellerman wrote:
> Cyril Bur <cyrilbur@gmail.com> writes:
>
> > On Wed, 3 Aug 2016 12:18:00 -0500
> > Jack Miller <jack@codezen.org> wrote:
> >
> >> (rebased on powerpc/next)
> >>
> >> This condenses the opal node searching into a single function that finds
> >> all compatible nodes, instead of just searching the ibm,opal children,
> >> for ipmi, flash, and prd similar to how opal-i2c nodes are found.
> >>
> >> Signed-off-by: Jack Miller <jack@codezen.org>
> >
> > Using a version of the related skiboot patch that may not be the final one:
> > Tested-by: Cyril Bur <cyrilbur@gmail.com>
>
> Thanks. The part I'm still not clear on is *why* we're moving them in
> skiboot?
Ostensibly so the actual flash device nodes can inherit the #size-cells /
#address-cells properties properly set in the flash parent node instead of
the ibm,opal node (which has them set to 0). This would be more correct if
anything actually started to honor these settings.
The only concrete effect though is stopping dtc (and thus fwts) from whinging
when you run skiboot's output DT through it.
- Jack
next prev parent reply other threads:[~2016-08-04 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 20:50 [PATCH] powernv: Search for new flash DT node location Jack Miller
2016-08-01 21:04 ` Jack Miller
2016-08-03 7:16 ` Michael Ellerman
2016-08-03 16:44 ` Jack Miller
2016-08-03 16:44 ` [PATCH] powernv: Simplify searching for compatible device nodes Jack Miller
2016-08-03 17:18 ` [PATCH v2] " Jack Miller
2016-08-04 7:27 ` Cyril Bur
2016-08-04 8:39 ` Michael Ellerman
2016-08-04 16:03 ` Jack Miller [this message]
2016-08-04 3:28 ` [PATCH] powernv: Search for new flash DT node location Michael Ellerman
2016-09-27 4:44 ` Stewart Smith
-- strict thread matches above, loose matches on Subject: below --
2016-08-11 0:32 [PATCH v2] powernv: Simplify searching for compatible device nodes Jack Miller
2016-10-19 5:58 ` Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804160312.GA30161@hypothesis \
--to=jack@codezen.org \
--cc=cyrilbur@gmail.com \
--cc=jk@ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).