From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hr2.samba.org (hr2.samba.org [144.76.82.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3s4mZX2f8QzDqQs for ; Thu, 4 Aug 2016 20:36:36 +1000 (AEST) Date: Thu, 4 Aug 2016 20:36:09 +1000 From: Anton Blanchard To: Christophe Leroy Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, agraf@suse.de, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: Align hot loops of memset() and backwards_memcpy() Message-ID: <20160804203609.73b02d85@kryten> In-Reply-To: References: <1470293602-11121-1-git-send-email-anton@ozlabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Christophe, > > Align the hot loops in our assembly implementation of memset() > > and backwards_memcpy(). > > > > backwards_memcpy() is called from tcp_v4_rcv(), so we might > > want to optimise this a little more. > > > > Signed-off-by: Anton Blanchard > > Shouldn't this patch be titled powerpc/64, as powerpc32 has a > different memset() ? Yeah, good point. Michael can you make this change if you choose to merge it? Anton > > --- > > arch/powerpc/lib/mem_64.S | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/powerpc/lib/mem_64.S b/arch/powerpc/lib/mem_64.S > > index 43435c6..eda7a96 100644 > > --- a/arch/powerpc/lib/mem_64.S > > +++ b/arch/powerpc/lib/mem_64.S > > @@ -37,6 +37,7 @@ _GLOBAL(memset) > > clrldi r5,r5,58 > > mtctr r0 > > beq 5f > > + .balign 16 > > 4: std r4,0(r6) > > std r4,8(r6) > > std r4,16(r6) > > @@ -90,6 +91,7 @@ _GLOBAL(backwards_memcpy) > > andi. r0,r6,3 > > mtctr r7 > > bne 5f > > + .balign 16 > > 1: lwz r7,-4(r4) > > lwzu r8,-8(r4) > > stw r7,-4(r6) > > >