From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH -net] net/ethernet: tundra: fix dump_eth_one warning in tsi108_eth
Date: Mon, 08 Aug 2016 13:08:40 -0700 (PDT) [thread overview]
Message-ID: <20160808.130840.276329308290273424.davem@davemloft.net> (raw)
In-Reply-To: <20160804200758.29835-1-paul.gortmaker@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Thu, 4 Aug 2016 16:07:58 -0400
> The call site for this function appears as:
>
> #ifdef DEBUG
> data->msg_enable = DEBUG;
> dump_eth_one(dev);
> #endif
>
> ...leading to the following warning for !DEBUG builds:
>
> drivers/net/ethernet/tundra/tsi108_eth.c:169:13: warning: 'dump_eth_one' defined but not used [-Wunused-function]
> static void dump_eth_one(struct net_device *dev)
> ^
>
> ...when using the arch/powerpc/configs/mpc7448_hpc2_defconfig
>
> Put the function definition under the same #ifdef as the call site
> to avoid the warning.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied, thanks.
prev parent reply other threads:[~2016-08-08 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 20:07 [PATCH -net] net/ethernet: tundra: fix dump_eth_one warning in tsi108_eth Paul Gortmaker
2016-08-08 20:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808.130840.276329308290273424.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).