From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3s9sFC1j3kzDqCb for ; Sat, 13 Aug 2016 03:24:15 +1000 (AEST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7CHJhF7129159 for ; Fri, 12 Aug 2016 13:24:12 -0400 Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) by mx0a-001b2d01.pphosted.com with ESMTP id 24rtx4vb3e-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 12 Aug 2016 13:24:12 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Aug 2016 11:24:11 -0600 Date: Fri, 12 Aug 2016 12:24:03 -0500 From: Reza Arbab To: Balbir Singh Cc: Rob Herring , Mark Rutland , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jonathan Corbet , Bharata B Rao , Nathan Fontenot , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node References: <1470680843-28702-1-git-send-email-arbab@linux.vnet.ibm.com> <1470680843-28702-4-git-send-email-arbab@linux.vnet.ibm.com> <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed In-Reply-To: <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com> Message-Id: <20160812172402.GA31526@arbab-vm.austin.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Aug 12, 2016 at 11:50:43AM +1000, Balbir Singh wrote: >On 09/08/16 04:27, Reza Arbab wrote: >> Remove the check which prevents us from hotplugging into an empty node. > >Do we want to do this only for ibm,hotplug-aperture compatible ranges? We could, but since past discussions and current testing have been unable to justify preventing hotplug to a memoryless node in the first place, I'm inclined to keep things simple. If some edge case is discovered, making it conditional as you describe will be a good solution. Thanks for your review! A v2 of this set is pending my investigation of Michael's suggestion to get node hotadd working. -- Reza Arbab