From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/8xx: use SPRN_EIE and SPRN_EID to enable/disable interrupts
Date: Thu, 18 Aug 2016 11:34:31 -0500 [thread overview]
Message-ID: <20160818163431.GB24467@gate.crashing.org> (raw)
In-Reply-To: <20160818155602.DAD601A2459@localhost.localdomain>
On Thu, Aug 18, 2016 at 05:56:02PM +0200, Christophe Leroy wrote:
> The 8xx has two special registers called EID (External Interrupt
> Disable) and EIE (External Interrupt Enable) for clearing/setting
> EE in MSR. It avoids the three instructions set mfmsr/ori/mtmsr or
> mfmsr/rlwinm/mtmsr.
All 8xx? What other models? (5xx for example).
> +/* Special MSR manipulation registers */
> +#define SPRN_EIE 80 /* External interrupt enable (EE=1, RI=1) */
> +#define SPRN_EID 81 /* External interrupt disable (EE=0, RI=1) */
> +#define SPRN_NRI 81 /* Non Recoverable interrupt (EE=0, RI=0) */
This is wrong (NRI is 82). Don't write code you cannot test / don't submit
code you haven't tested? :-)
Segher
next prev parent reply other threads:[~2016-08-18 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 15:56 [PATCH] powerpc/8xx: use SPRN_EIE and SPRN_EID to enable/disable interrupts Christophe Leroy
2016-08-18 16:34 ` Segher Boessenkool [this message]
2016-08-18 16:52 ` Christophe Leroy
2016-08-18 17:54 ` Segher Boessenkool
2016-08-19 6:59 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818163431.GB24467@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).