From: Cyril Bur <cyrilbur@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: wei.guo.simon@gmail.com, mikey@neuling.org
Subject: [PATCH v4 00/20] Consistent TM structures
Date: Tue, 6 Sep 2016 09:44:28 +1000 [thread overview]
Message-ID: <20160905234448.5866-1-cyrilbur@gmail.com> (raw)
v4: Address review from Mikey, comment and commit message changes.
Dropped patch "selftests/powerpc: Add TM tcheck helpers in C" as
it was unused.
V3:
In v2 the MSR_{FP,VEC,VSX} bits were left on (if in use) after a
reclaim which meant that signal code did the correct thing.
This also meant that the bits would stay on when a (transactional)
thread was not running and ptrace flush code would notice that tasks
not current have MSR_{FP,VEC,VSX} set when attempting to flush, this
is incorrect. The correct solution was to have the signal code make
decisions about the use of FP,VEC or VSX by observing the checkpointed
MSR and not the regs->msr. This meant adding another reference to
current in signal code which was getting messy.
Patch "powerpc: signals: Stop using current in signal code" addresses
this and allows for a cleaner fix.
Fix build issues for 32bit.
V2 Coverletter:
This series has grown considerably from v1.
Similarities with v1 include:
- Selftests are all the same, they have simply been split into several
patches with comments from MPE and Daniel Axtens incorporated. It
is possible some things slipped through the cracks selftest wise as
the focus has been on the final three patches.
- The final three patches have been reworked following extra testing
and from review by Simon Guo.
Differences include:
- Patches 2-5 are fixes for existing problems found in the course of
verifying the final three patches. In the case of "powerpc: Never
giveup a reclaimed thread when enabling kernel {fp, altivec, vsx}"
it has proven difficult to narrow down when the bug was introduced.
It does not exist in 3.8 when TM was introduced but does exist in 4.4.
I was unable to boot 3.13 (or 3.12) in an attempt to further bisect.
- As ptrace code was merged between v1 and v2, work was needed there
to make it fit in with the final three patches.
The overall aim of this series may have gotten lost here. The final
three patches are the goal here.
Cyril Bur (20):
selftests/powerpc: Compile selftests against headers without AT_HWCAP2
powerpc: Always restore FPU/VEC/VSX if hardware transactional memory
in use
powerpc: Add check_if_tm_restore_required() to giveup_all()
powerpc: Return the new MSR from msr_check_and_set()
powerpc: Never giveup a reclaimed thread when enabling kernel {fp,
altivec, vsx}
powerpc: signals: Stop using current in signal code
selftests/powerpc: Check for VSX preservation across userspace
preemption
selftests/powerpc: Rework FPU stack placement macros and move to
header file
selftests/powerpc: Move VMX stack frame macros to header file
selftests/powerpc: Introduce GPR asm helper header file
selftests/powerpc: Allow tests to extend their kill timeout
selftests/powerpc: Add TM tcheck helpers in C
selftests/powerpc: Check that signals always get delivered
selftests/powerpc: Add checks for transactional GPRs in signal
contexts
selftests/powerpc: Add checks for transactional FPUs in signal
contexts
selftests/powerpc: Add checks for transactional VMXs in signal
contexts
selftests/powerpc: Add checks for transactional VSXs in signal
contexts
powerpc: tm: Always use fp_state and vr_state to store live registers
powerpc: tm: Rename transct_(*) to ck(\1)_state
powerpc: Remove do_load_up_transact_{fpu,altivec}
arch/powerpc/include/asm/processor.h | 15 +-
arch/powerpc/include/asm/reg.h | 2 +-
arch/powerpc/include/asm/signal.h | 2 -
arch/powerpc/include/asm/tm.h | 5 -
arch/powerpc/kernel/asm-offsets.c | 12 +-
arch/powerpc/kernel/fpu.S | 26 --
arch/powerpc/kernel/process.c | 152 +++++------
arch/powerpc/kernel/ptrace.c | 278 +++++----------------
arch/powerpc/kernel/signal.c | 41 +--
arch/powerpc/kernel/signal.h | 18 +-
arch/powerpc/kernel/signal_32.c | 115 ++++-----
arch/powerpc/kernel/signal_64.c | 194 +++++++-------
arch/powerpc/kernel/tm.S | 94 +++----
arch/powerpc/kernel/traps.c | 12 +-
arch/powerpc/kernel/vector.S | 25 --
tools/testing/selftests/powerpc/Makefile | 1 +
tools/testing/selftests/powerpc/fpu_asm.h | 81 ++++++
tools/testing/selftests/powerpc/gpr_asm.h | 96 +++++++
tools/testing/selftests/powerpc/harness.c | 9 +-
tools/testing/selftests/powerpc/math/Makefile | 4 +-
tools/testing/selftests/powerpc/math/fpu_asm.S | 73 +-----
tools/testing/selftests/powerpc/math/vmx_asm.S | 85 +------
tools/testing/selftests/powerpc/math/vsx_asm.S | 61 +++++
tools/testing/selftests/powerpc/math/vsx_preempt.c | 147 +++++++++++
tools/testing/selftests/powerpc/signal/Makefile | 12 +
tools/testing/selftests/powerpc/signal/signal.S | 50 ++++
tools/testing/selftests/powerpc/signal/signal.c | 111 ++++++++
tools/testing/selftests/powerpc/signal/signal_tm.c | 110 ++++++++
tools/testing/selftests/powerpc/tm/Makefile | 8 +-
.../powerpc/tm/tm-signal-context-chk-fpu.c | 92 +++++++
.../powerpc/tm/tm-signal-context-chk-gpr.c | 90 +++++++
.../powerpc/tm/tm-signal-context-chk-vmx.c | 110 ++++++++
.../powerpc/tm/tm-signal-context-chk-vsx.c | 125 +++++++++
tools/testing/selftests/powerpc/tm/tm-signal.S | 114 +++++++++
tools/testing/selftests/powerpc/tm/tm.h | 27 ++
tools/testing/selftests/powerpc/utils.h | 9 +-
tools/testing/selftests/powerpc/vmx_asm.h | 98 ++++++++
tools/testing/selftests/powerpc/vsx_asm.h | 71 ++++++
38 files changed, 1844 insertions(+), 731 deletions(-)
create mode 100644 tools/testing/selftests/powerpc/fpu_asm.h
create mode 100644 tools/testing/selftests/powerpc/gpr_asm.h
create mode 100644 tools/testing/selftests/powerpc/math/vsx_asm.S
create mode 100644 tools/testing/selftests/powerpc/math/vsx_preempt.c
create mode 100644 tools/testing/selftests/powerpc/signal/Makefile
create mode 100644 tools/testing/selftests/powerpc/signal/signal.S
create mode 100644 tools/testing/selftests/powerpc/signal/signal.c
create mode 100644 tools/testing/selftests/powerpc/signal/signal_tm.c
create mode 100644 tools/testing/selftests/powerpc/tm/tm-signal-context-chk-fpu.c
create mode 100644 tools/testing/selftests/powerpc/tm/tm-signal-context-chk-gpr.c
create mode 100644 tools/testing/selftests/powerpc/tm/tm-signal-context-chk-vmx.c
create mode 100644 tools/testing/selftests/powerpc/tm/tm-signal-context-chk-vsx.c
create mode 100644 tools/testing/selftests/powerpc/tm/tm-signal.S
create mode 100644 tools/testing/selftests/powerpc/vmx_asm.h
create mode 100644 tools/testing/selftests/powerpc/vsx_asm.h
--
2.9.3
next reply other threads:[~2016-09-05 23:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 23:44 Cyril Bur [this message]
2016-09-05 23:44 ` [PATCH v4 01/20] selftests/powerpc: Compile selftests against headers without AT_HWCAP2 Cyril Bur
2016-09-05 23:44 ` [PATCH v4 02/20] powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use Cyril Bur
2016-09-05 23:44 ` [PATCH v4 03/20] powerpc: Add check_if_tm_restore_required() to giveup_all() Cyril Bur
2016-09-05 23:44 ` [PATCH v4 04/20] powerpc: Return the new MSR from msr_check_and_set() Cyril Bur
2016-09-05 23:44 ` [PATCH v4 05/20] powerpc: Never giveup a reclaimed thread when enabling kernel {fp, altivec, vsx} Cyril Bur
2016-09-05 23:44 ` [PATCH v4 06/20] powerpc: signals: Stop using current in signal code Cyril Bur
2016-09-05 23:44 ` [PATCH v4 07/20] selftests/powerpc: Check for VSX preservation across userspace preemption Cyril Bur
2016-09-05 23:44 ` [PATCH v4 08/20] selftests/powerpc: Rework FPU stack placement macros and move to header file Cyril Bur
2016-09-05 23:44 ` [PATCH v4 09/20] selftests/powerpc: Move VMX stack frame macros " Cyril Bur
2016-09-05 23:44 ` [PATCH v4 10/20] selftests/powerpc: Introduce GPR asm helper " Cyril Bur
2016-09-05 23:44 ` [PATCH v4 11/20] selftests/powerpc: Allow tests to extend their kill timeout Cyril Bur
2016-09-05 23:44 ` [PATCH v4 12/20] selftests/powerpc: Add TM tcheck helpers in C Cyril Bur
2016-09-05 23:44 ` [PATCH v4 13/20] selftests/powerpc: Check that signals always get delivered Cyril Bur
2016-09-05 23:44 ` [PATCH v4 14/20] selftests/powerpc: Add checks for transactional GPRs in signal contexts Cyril Bur
2016-09-05 23:44 ` [PATCH v4 15/20] selftests/powerpc: Add checks for transactional FPUs " Cyril Bur
2016-09-05 23:44 ` [PATCH v4 16/20] selftests/powerpc: Add checks for transactional VMXs " Cyril Bur
2016-09-05 23:44 ` [PATCH v4 17/20] selftests/powerpc: Add checks for transactional VSXs " Cyril Bur
2016-09-05 23:44 ` [PATCH v4 18/20] powerpc: tm: Always use fp_state and vr_state to store live registers Cyril Bur
2016-09-05 23:44 ` [PATCH v4 19/20] powerpc: tm: Rename transct_(*) to ck(\1)_state Cyril Bur
2016-09-05 23:44 ` [PATCH v4 20/20] powerpc: Remove do_load_up_transact_{fpu,altivec} Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905234448.5866-1-cyrilbur@gmail.com \
--to=cyrilbur@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=wei.guo.simon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).