From: Russell Currey <ruscur@russell.cc>
To: linuxppc-dev@lists.ozlabs.org
Cc: Russell Currey <ruscur@russell.cc>
Subject: [PATCH 3/3] powerpc/eeh: Skip finding bus until after failure reporting
Date: Mon, 12 Sep 2016 14:17:24 +1000 [thread overview]
Message-ID: <20160912041724.16646-3-ruscur@russell.cc> (raw)
In-Reply-To: <20160912041724.16646-1-ruscur@russell.cc>
In eeh_handle_special_event(), eeh_pe_bus_get() is called before calling
eeh_report_failure() on every device under a PE. If a PE was missing a
bus for some reason, the error would occur before reporting failure, even
though eeh_report_failure() doesn't require a bus.
Fix this by moving the bus retrieval and error check after the
eeh_report_failure() calls.
Cc: stable #3.10+
Signed-off-by: Russell Currey <ruscur@russell.cc>
---
arch/powerpc/kernel/eeh_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
index 29aa8d1..a62be72 100644
--- a/arch/powerpc/kernel/eeh_driver.c
+++ b/arch/powerpc/kernel/eeh_driver.c
@@ -993,6 +993,8 @@ static void eeh_handle_special_event(void)
/* Notify all devices to be down */
eeh_pe_state_clear(pe, EEH_PE_PRI_BUS);
+ eeh_pe_dev_traverse(pe,
+ eeh_report_failure, NULL);
bus = eeh_pe_bus_get(phb_pe);
if (!bus) {
pr_err("%s: Cannot find PCI bus for "
@@ -1002,8 +1004,6 @@ static void eeh_handle_special_event(void)
pe->addr);
break;
}
- eeh_pe_dev_traverse(pe,
- eeh_report_failure, NULL);
pci_hp_remove_devices(bus);
}
pci_unlock_rescan_remove();
--
2.9.3
next prev parent reply other threads:[~2016-09-12 4:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 4:17 [PATCH 1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get Russell Currey
2016-09-12 4:17 ` [PATCH 2/3] powernv/eeh: Skip finding bus for VF resets Russell Currey
2016-09-12 4:43 ` Andrew Donnellan
2016-09-12 4:17 ` Russell Currey [this message]
2016-09-12 4:41 ` [PATCH 3/3] powerpc/eeh: Skip finding bus until after failure reporting Andrew Donnellan
2016-09-12 4:39 ` [PATCH 1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get Andrew Donnellan
2016-09-21 4:02 ` [1/3] " Michael Ellerman
2016-09-21 4:06 ` Russell Currey
2016-09-25 3:00 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912041724.16646-3-ruscur@russell.cc \
--to=ruscur@russell.cc \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).