* [PATCH] dma/fsldma : Unmap region obtained by of_iomap
@ 2016-09-28 10:45 Arvind Yadav
2016-09-29 16:57 ` Leo Li
2016-09-30 17:56 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2016-09-28 10:45 UTC (permalink / raw)
To: leoli, zw, vinod.koul
Cc: dan.j.williams, linuxppc-dev, dmaengine, linux-kernel
Free memory mapping, if probe is not successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/dma/fsldma.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 911b717..7ba8944 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -1351,7 +1351,7 @@ static int fsldma_of_probe(struct platform_device *op)
if (!fdev->regs) {
dev_err(&op->dev, "unable to ioremap registers\n");
err = -ENOMEM;
- goto out_free_fdev;
+ goto out_free;
}
/* map the channel IRQ if it exists, but don't hookup the handler yet */
@@ -1416,6 +1416,8 @@ static int fsldma_of_probe(struct platform_device *op)
out_free_fdev:
irq_dispose_mapping(fdev->irq);
+ iounmap(fdev->regs);
+out_free:
kfree(fdev);
out_return:
return err;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] dma/fsldma : Unmap region obtained by of_iomap
2016-09-28 10:45 [PATCH] dma/fsldma : Unmap region obtained by of_iomap Arvind Yadav
@ 2016-09-29 16:57 ` Leo Li
2016-09-30 17:56 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Leo Li @ 2016-09-29 16:57 UTC (permalink / raw)
To: Arvind Yadav, leoli@freescale.com, vinod.koul@intel.com
Cc: dan.j.williams@intel.com, linuxppc-dev@lists.ozlabs.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Arvind Yadav [mailto:arvind.yadav.cs@gmail.com]
> Sent: Wednesday, September 28, 2016 5:45 AM
> To: leoli@freescale.com; zw@zh-kernel.org; vinod.koul@intel.com
> Cc: dan.j.williams@intel.com; linuxppc-dev@lists.ozlabs.org;
> dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] dma/fsldma : Unmap region obtained by of_iomap
>=20
> Free memory mapping, if probe is not successful.
>=20
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> drivers/dma/fsldma.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index
> 911b717..7ba8944 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1351,7 +1351,7 @@ static int fsldma_of_probe(struct platform_device
> *op)
> if (!fdev->regs) {
> dev_err(&op->dev, "unable to ioremap registers\n");
> err =3D -ENOMEM;
> - goto out_free_fdev;
> + goto out_free;
> }
>=20
> /* map the channel IRQ if it exists, but don't hookup the handler yet *=
/
> @@ -1416,6 +1416,8 @@ static int fsldma_of_probe(struct platform_device
> *op)
>=20
> out_free_fdev:
> irq_dispose_mapping(fdev->irq);
> + iounmap(fdev->regs);
> +out_free:
> kfree(fdev);
> out_return:
> return err;
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dma/fsldma : Unmap region obtained by of_iomap
2016-09-28 10:45 [PATCH] dma/fsldma : Unmap region obtained by of_iomap Arvind Yadav
2016-09-29 16:57 ` Leo Li
@ 2016-09-30 17:56 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2016-09-30 17:56 UTC (permalink / raw)
To: Arvind Yadav
Cc: leoli, zw, dan.j.williams, linuxppc-dev, dmaengine, linux-kernel
On Wed, Sep 28, 2016 at 04:15:11PM +0530, Arvind Yadav wrote:
> Free memory mapping, if probe is not successful.
Please use proper subsystem tags for patches. Hint: use git log to find that
out
Applied after fixing the tag
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-30 17:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-28 10:45 [PATCH] dma/fsldma : Unmap region obtained by of_iomap Arvind Yadav
2016-09-29 16:57 ` Leo Li
2016-09-30 17:56 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).