LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: Minghuan Lian <minghuan.Lian@freescale.com>,
	Mingkai Hu <mingkai.hu@freescale.com>,
	Roy Zang <tie-fei.zang@freescale.com>
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v2 0/7] PCI: layerscape: Cleanups
Date: Wed, 12 Oct 2016 08:57:22 -0500	[thread overview]
Message-ID: <20161012135413.29815.75484.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw)

  - Add local "dev" pointers to reduce repetition of things like
    "&pdev->dev".

  - Remove platform drvdata because it appears unused (we called
    platform_set_drvdata() but not platform_get_drvdata()).

  - Remove redundant struct members.

  - Pass device-specific struct to internal functions for consistency.

  - Move struct pcie_port setup to probe function for consistency.

  - Remove unused ls_add_pcie_port() platform_device argument.

Nothing here should change the behavior of the driver.

Changes from v1:
  I dropped the following patch because it was a lot of churn for
  questionable benefit:
    PCI: layerscape: Name private struct pointer "ls" consistently

---

Bjorn Helgaas (7):
      PCI: layerscape: Add local struct device pointers
      PCI: layerscape: Remove unused platform data
      PCI: layerscape: Remove redundant struct ls_pcie.dbi
      PCI: layerscape: Pass device-specific struct to internal functions
      PCI: layerscape: Move struct pcie_port setup to probe function
      PCI: layerscape: Remove unused ls_add_pcie_port() platform_device arg
      PCI: layerscape: Reorder struct ls_pcie


 drivers/pci/host/pci-layerscape.c |   65 +++++++++++++++++++------------------
 1 file changed, 33 insertions(+), 32 deletions(-)

             reply	other threads:[~2016-10-12 13:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 13:57 Bjorn Helgaas [this message]
2016-10-12 13:57 ` [PATCH v2 1/7] PCI: layerscape: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:57 ` [PATCH v2 2/7] PCI: layerscape: Remove unused platform data Bjorn Helgaas
2016-10-12 13:57 ` [PATCH v2 3/7] PCI: layerscape: Remove redundant struct ls_pcie.dbi Bjorn Helgaas
2016-10-12 13:57 ` [PATCH v2 4/7] PCI: layerscape: Pass device-specific struct to internal functions Bjorn Helgaas
2016-10-12 13:58 ` [PATCH v2 5/7] PCI: layerscape: Move struct pcie_port setup to probe function Bjorn Helgaas
2016-10-12 13:58 ` [PATCH v2 6/7] PCI: layerscape: Remove unused ls_add_pcie_port() platform_device arg Bjorn Helgaas
2016-10-12 13:58 ` [PATCH v2 7/7] PCI: layerscape: Reorder struct ls_pcie Bjorn Helgaas
2016-10-12 16:06 ` [PATCH v2 0/7] PCI: layerscape: Cleanups Bjorn Helgaas
2016-10-12 16:32   ` Roy Zang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161012135413.29815.75484.stgit@bhelgaas-glaptop2.roam.corp.google.com \
    --to=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=minghuan.Lian@freescale.com \
    --cc=mingkai.hu@freescale.com \
    --cc=tie-fei.zang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox