From: Tejun Heo <tj@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
jiangshanlai@gmail.com, akpm@linux-foundation.org,
kernel-team@fb.com,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot)
Date: Fri, 14 Oct 2016 11:07:57 -0400 [thread overview]
Message-ID: <20161014150757.GA11102@mtj.duckdns.org> (raw)
In-Reply-To: <87a8eb5dwa.fsf@concordia.ellerman.id.au>
Hello, Michael.
On Tue, Oct 11, 2016 at 10:22:13PM +1100, Michael Ellerman wrote:
> The oops happens because we're in enqueue_task_fair() and p->se->cfs_rq
> is NULL.
>
> The cfs_rq is NULL because we did set_task_rq(p, 2048), where 2048 is
> NR_CPUS. That causes us to index past the end of the tg->cfs_rq array in
> set_task_rq() and happen to get NULL.
>
> We never should have done set_task_rq(p, 2048), because 2048 is >=
> nr_cpu_ids, which means it's not a valid CPU number, and set_task_rq()
> doesn't cope with that.
Hmm... it doesn't reproduce it here and can't see how the commit would
affect this given that it doesn't really change when the kworker
kthreads are being created.
> Presumably we shouldn't be ending up with tsk_cpus_allowed() being
> empty, but I haven't had time to track down why that's happening.
Can you please add WARN_ON_ONCE(!tsk_nr_cpus_allowed(p)) to
select_task_rq() and post what that says?
Thanks.
--
tejun
next prev parent reply other threads:[~2016-10-14 15:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1473967821-24363-1-git-send-email-tj@kernel.org>
[not found] ` <1473967821-24363-2-git-send-email-tj@kernel.org>
[not found] ` <20160917172314.GB10771@mtj.duckdns.org>
2016-10-10 10:22 ` Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Michael Ellerman
2016-10-10 11:17 ` Balbir Singh
2016-10-10 12:53 ` Tejun Heo
2016-10-10 13:22 ` Balbir Singh
2016-10-10 13:02 ` Tejun Heo
2016-10-10 13:14 ` Tejun Heo
2016-10-11 11:22 ` Michael Ellerman
2016-10-11 12:21 ` Balbir Singh
2016-10-14 15:08 ` Tejun Heo
2016-10-15 3:43 ` Balbir Singh
2016-10-14 15:07 ` Tejun Heo [this message]
2016-10-15 1:25 ` Balbir Singh
2016-10-15 9:48 ` Michael Ellerman
2016-10-17 18:13 ` Tejun Heo
2016-10-17 12:24 ` Michael Ellerman
2016-10-17 12:51 ` Balbir Singh
2016-10-18 2:35 ` Michael Ellerman
2016-10-17 18:15 ` Tejun Heo
2016-10-17 19:30 ` Tejun Heo
2016-10-18 4:37 ` Michael Ellerman
2016-10-18 18:58 ` Tejun Heo
2016-10-19 11:16 ` Michael Ellerman
2016-10-19 16:15 ` [PATCH wq/for-4.10] workqueue: move wq_numa_init() to workqueue_init() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014150757.GA11102@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).