* [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"
@ 2016-10-24 22:02 Colin King
2016-10-24 22:13 ` Kees Cook
2016-10-25 14:02 ` Nathan Fontenot
0 siblings, 2 replies; 6+ messages in thread
From: Colin King @ 2016-10-24 22:02 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Nathan Fontenot, Heiko Carstens, Kees Cook, Rashmica Gupta,
linuxppc-dev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
trivial fix to spelling mistake in pr_debug message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index a1b63e0..c8929cb 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
{
int rc;
- pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+ pr_debug("Attempting to remove CPU %s, drc index: %x\n",
dn->name, drc_index);
rc = dlpar_offline_cpu(dn);
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"
2016-10-24 22:02 [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting" Colin King
@ 2016-10-24 22:13 ` Kees Cook
2016-10-24 22:20 ` Joe Perches
2016-10-25 14:02 ` Nathan Fontenot
1 sibling, 1 reply; 6+ messages in thread
From: Kees Cook @ 2016-10-24 22:13 UTC (permalink / raw)
To: Colin King
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Nathan Fontenot, Heiko Carstens, Rashmica Gupta,
linuxppc-dev@lists.ozlabs.org, LKML, Joe Perches
On Mon, Oct 24, 2016 at 3:02 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in pr_debug message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> index a1b63e0..c8929cb 100644
> --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
> +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
> {
> int rc;
>
> - pr_debug("Attemping to remove CPU %s, drc index: %x\n",
> + pr_debug("Attempting to remove CPU %s, drc index: %x\n",
> dn->name, drc_index);
>
> rc = dlpar_offline_cpu(dn);
> --
> 2.9.3
Reviewed-by: Kees Cook <keescook@chromium.org>
scripts/spelling.txt should likely get an addition for "attemping". It
already has "attemps"...
-Kees
--
Kees Cook
Nexus Security
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"
2016-10-24 22:13 ` Kees Cook
@ 2016-10-24 22:20 ` Joe Perches
2016-10-24 22:24 ` Colin Ian King
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2016-10-24 22:20 UTC (permalink / raw)
To: Kees Cook, Colin King
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Nathan Fontenot, Heiko Carstens, Rashmica Gupta,
linuxppc-dev@lists.ozlabs.org, LKML
On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote:
> On Mon, Oct 24, 2016 at 3:02 PM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > trivial fix to spelling mistake in pr_debug message
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> > index a1b63e0..c8929cb 100644
> > --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
> > +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> > @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
> > {
> > int rc;
> >
> > - pr_debug("Attemping to remove CPU %s, drc index: %x\n",
> > + pr_debug("Attempting to remove CPU %s, drc index: %x\n",
> > dn->name, drc_index);
> >
> > rc = dlpar_offline_cpu(dn);
> > --
> > 2.9.3
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> scripts/spelling.txt should likely get an addition for "attemping". It
> already has "attemps"...
There may not be enough of these to be useful and to my
knowledge Colin isn't fixing comments
$ grep -rP --include=*.[ch] -wi "at+emp*t?ing" * | grep -vi attempting
arch/x86/platform/uv/uv_nmi.c:/* Ping non-responding cpus attemping to force them into the NMI handler */
arch/powerpc/platforms/pseries/hotplug-cpu.c: pr_debug("Attemping to remove CPU %s, drc index: %x\n",
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"
2016-10-24 22:20 ` Joe Perches
@ 2016-10-24 22:24 ` Colin Ian King
0 siblings, 0 replies; 6+ messages in thread
From: Colin Ian King @ 2016-10-24 22:24 UTC (permalink / raw)
To: Joe Perches, Kees Cook
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Nathan Fontenot, Heiko Carstens, Rashmica Gupta,
linuxppc-dev@lists.ozlabs.org, LKML
On 24/10/16 23:20, Joe Perches wrote:
> On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote:
>> On Mon, Oct 24, 2016 at 3:02 PM, Colin King <colin.king@canonical.com> wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> trivial fix to spelling mistake in pr_debug message
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
>>> index a1b63e0..c8929cb 100644
>>> --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
>>> +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
>>> @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
>>> {
>>> int rc;
>>>
>>> - pr_debug("Attemping to remove CPU %s, drc index: %x\n",
>>> + pr_debug("Attempting to remove CPU %s, drc index: %x\n",
>>> dn->name, drc_index);
>>>
>>> rc = dlpar_offline_cpu(dn);
>>> --
>>> 2.9.3
>>
>> Reviewed-by: Kees Cook <keescook@chromium.org>
>>
>> scripts/spelling.txt should likely get an addition for "attemping". It
>> already has "attemps"...
>
> There may not be enough of these to be useful and to my
> knowledge Colin isn't fixing comments
Indeed, I'm just using my kernelscan tool to scrape for errors in kernel
messages as these are seen by users as opposed to comments. Plus the
occurrences of the mistakes I'm finding are generally very small.
>
> $ grep -rP --include=*.[ch] -wi "at+emp*t?ing" * | grep -vi attempting
> arch/x86/platform/uv/uv_nmi.c:/* Ping non-responding cpus attemping to force them into the NMI handler */
> arch/powerpc/platforms/pseries/hotplug-cpu.c: pr_debug("Attemping to remove CPU %s, drc index: %x\n",
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"
2016-10-24 22:02 [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting" Colin King
2016-10-24 22:13 ` Kees Cook
@ 2016-10-25 14:02 ` Nathan Fontenot
1 sibling, 0 replies; 6+ messages in thread
From: Nathan Fontenot @ 2016-10-25 14:02 UTC (permalink / raw)
To: Colin King, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Heiko Carstens, Kees Cook, Rashmica Gupta,
linuxppc-dev
Cc: linux-kernel
On 10/24/2016 05:02 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in pr_debug message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> ---
> arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> index a1b63e0..c8929cb 100644
> --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
> +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
> {
> int rc;
>
> - pr_debug("Attemping to remove CPU %s, drc index: %x\n",
> + pr_debug("Attempting to remove CPU %s, drc index: %x\n",
> dn->name, drc_index);
>
> rc = dlpar_offline_cpu(dn);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"
@ 2017-06-04 22:40 Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-06-04 22:40 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Ingo Molnar, Rashmica Gupta, linuxppc-dev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to spelling mistake in pr_debug message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index 7bc0e91f8715..6afd1efd3633 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -554,7 +554,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
{
int rc;
- pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+ pr_debug("Attempting to remove CPU %s, drc index: %x\n",
dn->name, drc_index);
rc = dlpar_offline_cpu(dn);
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-04 22:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-24 22:02 [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting" Colin King
2016-10-24 22:13 ` Kees Cook
2016-10-24 22:20 ` Joe Perches
2016-10-24 22:24 ` Colin Ian King
2016-10-25 14:02 ` Nathan Fontenot
-- strict thread matches above, loose matches on Subject: below --
2017-06-04 22:40 Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).