From: Davidlohr Bueso <dave@stgolabs.net>
To: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-s390@vger.kernel.org,
xen-devel-request@lists.xenproject.org, kvm@vger.kernel.org,
xen-devel@lists.xenproject.org, x86@kernel.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
mingo@redhat.com, peterz@infradead.org,
paulmck@linux.vnet.ibm.com, will.deacon@arm.com,
kernellwp@gmail.com, jgross@suse.com, pbonzini@redhat.com,
bsingharora@gmail.com, boqun.feng@gmail.com,
borntraeger@de.ibm.com, rkrcmar@redhat.com,
David.Laight@ACULAB.COM
Subject: Re: [PATCH v6 02/11] locking/osq: Drop the overload of osq_lock()
Date: Sat, 29 Oct 2016 09:52:16 -0700 [thread overview]
Message-ID: <20161029165216.GA17451@linux-80c1.suse> (raw)
In-Reply-To: <1477642287-24104-3-git-send-email-xinhui.pan@linux.vnet.ibm.com>
On Fri, 28 Oct 2016, Pan Xinhui wrote:
> /*
> * If we need to reschedule bail... so we can block.
>+ * Use vcpu_is_preempted to detech lock holder preemption issue
^^ detect
>+ * and break.
Could you please remove the rest of this comment? Its just noise to point out
that vcpu_is_preempted is a macro defined by arch/false. This is standard protocol
in the kernel.
Same goes for all locks you change with this.
Thanks,
Davidlohr
> * vcpu_is_preempted is a macro defined by false if
>+ * arch does not support vcpu preempted check,
> */
>- if (need_resched())
>+ if (need_resched() || vcpu_is_preempted(node_cpu(node->prev)))
> goto unqueue;
>
> cpu_relax_lowlatency();
>--
>2.4.11
>
next prev parent reply other threads:[~2016-10-29 16:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 8:11 [PATCH v6 00/11] implement vcpu preempted check Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 01/11] kernel/sched: introduce vcpu preempted check interface Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 02/11] locking/osq: Drop the overload of osq_lock() Pan Xinhui
2016-10-29 16:52 ` Davidlohr Bueso [this message]
2016-10-30 14:39 ` Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 03/11] kernel/locking: Drop the overload of {mutex, rwsem}_spin_on_owner Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 04/11] powerpc/spinlock: support vcpu preempted check Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 05/11] s390/spinlock: Provide vcpu_is_preempted Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 06/11] x86, paravirt: Add interface to support kvm/xen vcpu preempted check Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 07/11] KVM: Introduce kvm_write_guest_offset_cached Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 08/11] x86, kvm/x86.c: support vcpu preempted check Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 09/11] x86, kernel/kvm.c: " Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 10/11] x86, xen: " Pan Xinhui
2016-10-28 19:43 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-29 4:26 ` Pan Xinhui
2016-10-28 8:11 ` [PATCH v6 11/11] Documentation: virtual: kvm: Support " Pan Xinhui
2016-10-28 9:57 ` [PATCH v6 00/11] implement " Paolo Bonzini
2016-10-28 19:38 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-29 4:37 ` Pan Xinhui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161029165216.GA17451@linux-80c1.suse \
--to=dave@stgolabs.net \
--cc=David.Laight@ACULAB.COM \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=bsingharora@gmail.com \
--cc=jgross@suse.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=xen-devel-request@lists.xenproject.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xinhui.pan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).