* [PATCH] powerpc/mm/coproc: Handle bad address on coproc slb fault
@ 2016-11-15 15:06 Aneesh Kumar K.V
2016-11-16 0:08 ` Balbir Singh
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aneesh Kumar K.V @ 2016-11-15 15:06 UTC (permalink / raw)
To: benh, paulus, mpe, Frederic Barrat, imunsie
Cc: linuxppc-dev, Aneesh Kumar K.V
VSID 0 is bad address. Don't create slb entries on coproc fault for
bad address
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
NOTE: note tested
arch/powerpc/mm/copro_fault.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/mm/copro_fault.c b/arch/powerpc/mm/copro_fault.c
index 362954f98029..aaa7ec6788b9 100644
--- a/arch/powerpc/mm/copro_fault.c
+++ b/arch/powerpc/mm/copro_fault.c
@@ -134,6 +134,9 @@ int copro_calculate_slb(struct mm_struct *mm, u64 ea, struct copro_slb *slb)
pr_debug("%s: invalid region access at %016llx\n", __func__, ea);
return 1;
}
+ /* Bad address */
+ if (!vsid)
+ return 1;
vsid = (vsid << slb_vsid_shift(ssize)) | vsidkey;
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc/mm/coproc: Handle bad address on coproc slb fault
2016-11-15 15:06 [PATCH] powerpc/mm/coproc: Handle bad address on coproc slb fault Aneesh Kumar K.V
@ 2016-11-16 0:08 ` Balbir Singh
2016-11-16 1:11 ` Ian Munsie
2016-11-25 0:04 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Balbir Singh @ 2016-11-16 0:08 UTC (permalink / raw)
To: Aneesh Kumar K.V, benh, paulus, mpe, Frederic Barrat, imunsie
Cc: linuxppc-dev
On 16/11/16 02:06, Aneesh Kumar K.V wrote:
> VSID 0 is bad address. Don't create slb entries on coproc fault for
> bad address
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
> NOTE: note tested
^^^ ?
>
> arch/powerpc/mm/copro_fault.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/mm/copro_fault.c b/arch/powerpc/mm/copro_fault.c
> index 362954f98029..aaa7ec6788b9 100644
> --- a/arch/powerpc/mm/copro_fault.c
> +++ b/arch/powerpc/mm/copro_fault.c
> @@ -134,6 +134,9 @@ int copro_calculate_slb(struct mm_struct *mm, u64 ea, struct copro_slb *slb)
> pr_debug("%s: invalid region access at %016llx\n", __func__, ea);
> return 1;
> }
> + /* Bad address */
> + if (!vsid)
> + return 1;
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Balbir Singh.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc/mm/coproc: Handle bad address on coproc slb fault
2016-11-15 15:06 [PATCH] powerpc/mm/coproc: Handle bad address on coproc slb fault Aneesh Kumar K.V
2016-11-16 0:08 ` Balbir Singh
@ 2016-11-16 1:11 ` Ian Munsie
2016-11-25 0:04 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Ian Munsie @ 2016-11-16 1:11 UTC (permalink / raw)
To: Aneesh Kumar K.V
Cc: benh, paulus, Michael Ellerman, Frederic Barrat, linuxppc-dev
Reviewed-by: Ian Munsie <imunsie@au1.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: powerpc/mm/coproc: Handle bad address on coproc slb fault
2016-11-15 15:06 [PATCH] powerpc/mm/coproc: Handle bad address on coproc slb fault Aneesh Kumar K.V
2016-11-16 0:08 ` Balbir Singh
2016-11-16 1:11 ` Ian Munsie
@ 2016-11-25 0:04 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2016-11-25 0:04 UTC (permalink / raw)
To: Aneesh Kumar K.V, benh, paulus, Frederic Barrat, imunsie
Cc: linuxppc-dev, Aneesh Kumar K.V
On Tue, 2016-11-15 at 15:06:06 UTC, "Aneesh Kumar K.V" wrote:
> VSID 0 is bad address. Don't create slb entries on coproc fault for
> bad address
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Reviewed-by: Balbir Singh <bsingharora@gmail.com>
> Reviewed-by: Ian Munsie <imunsie@au1.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/64168f4296fa507ba059307984cddc
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-25 0:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 15:06 [PATCH] powerpc/mm/coproc: Handle bad address on coproc slb fault Aneesh Kumar K.V
2016-11-16 0:08 ` Balbir Singh
2016-11-16 1:11 ` Ian Munsie
2016-11-25 0:04 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).