From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>,
Anton Blanchard <anton@samba.org>,
linuxppc-dev@lists.ozlabs.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Subject: Re: [RFC PATCH 1/4] powerpc: asm: introduce new macros for assembly globals
Date: Fri, 18 Nov 2016 17:06:54 +0530 [thread overview]
Message-ID: <20161118113654.GH4019@naverao1-tp.localdomain> (raw)
In-Reply-To: <87poltgm6e.fsf@concordia.ellerman.id.au>
On 2016/11/18 08:41PM, Michael Ellerman wrote:
> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes:
>
> > - Introduce _GLOBAL_SYM() for global symbols in assembly. This helps
> > reduce verbosity of assembly files.
>
> Unfortunately you've walked into a bit of mine field here :)
>
> In user space they use FUNC_START() to declare the start of a function,
> and we should do the same. Anton added FUNC_START/END, but didn't quite
> get around to converting everything, see 151f25112ff7 ("powerpc: define
> FUNC_START/FUNC_END").
>
> So what I'd like is all uses of _GLOBAL() to become FUNC_START(), and
> then we can change _GLOBAL() to just define a global symbol.
Can't say I didn't get tempted to rename _GLOBAL() to _GLOBAL_FUNC() :D
I'll convert the files I touch.
>
> We can probably decouple that from most of this series though, as I
> mentioned in my other reply, just by using _ASM_NOKPROBE_SYMBOL().
Sure.
Thanks!
- Naveen
next prev parent reply other threads:[~2016-11-18 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 15:08 [RFC PATCH 0/4] Blacklist powerpc exception vectors from kprobes Naveen N. Rao
2016-11-17 15:08 ` [RFC PATCH 1/4] powerpc: asm: introduce new macros for assembly globals Naveen N. Rao
2016-11-18 9:41 ` Michael Ellerman
2016-11-18 11:36 ` Naveen N. Rao [this message]
2016-11-17 15:08 ` [RFC PATCH 2/4] powerpc: kprobe: add arch specific blacklist Naveen N. Rao
2016-11-18 5:48 ` Michael Ellerman
2016-11-18 7:04 ` Masami Hiramatsu
2016-11-18 11:24 ` Naveen N. Rao
2016-11-18 11:22 ` Naveen N. Rao
2016-11-17 15:08 ` [RFC PATCH 3/4] powerpc: mm/slb: convert slb_low.S to use the new macros Naveen N. Rao
2016-11-17 15:08 ` [RFC PATCH 4/4] powerpc: mm/slb: blacklist symbols from kprobe Naveen N. Rao
2016-11-18 9:36 ` Michael Ellerman
2016-11-18 11:26 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118113654.GH4019@naverao1-tp.localdomain \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhiramat@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).