From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tLMDX6W3MzDvyG for ; Sat, 19 Nov 2016 15:23:24 +1100 (AEDT) Date: Sat, 19 Nov 2016 15:19:54 +1100 From: Paul Mackerras To: "Aneesh Kumar K.V" Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 02/13] powerpc/64: Provide functions for accessing POWER9 partition table Message-ID: <20161119041954.GF29462@fergus.ozlabs.ibm.com> References: <1479454122-26994-1-git-send-email-paulus@ozlabs.org> <1479454122-26994-3-git-send-email-paulus@ozlabs.org> <878tsgoobx.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <878tsgoobx.fsf@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Nov 18, 2016 at 07:57:30PM +0530, Aneesh Kumar K.V wrote: > Paul Mackerras writes: > + > > + /* Global flush of TLBs and partition table caches for this lpid */ > > + asm volatile("ptesync"); > > + asm volatile(PPC_TLBIE_5(%0,%1,2,0,0) : : "r"(0x800), "r" (lpid)); > > + asm volatile("eieio; tlbsync; ptesync" : : : "memory"); > > +} > > > It would be nice to convert that 0x800 to a documented IS value or better use > radix__flush_tlb_pid() ? Well, not radix__flush_tlb_pid - this isn't radix and it isn't a PID flush. I could use TLBIEL_INVAL_SET_LPID except the name implies it's for tlbiel and this is a tlbie. Paul.