From: Nicholas Piggin <npiggin@gmail.com>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: benh@kernel.crashing.org, mpe@ellerman.id.au, anton@samba.org,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 07/12] powerpc: Add support to take additional parameter in MASKABLE_* macro
Date: Tue, 20 Dec 2016 12:36:07 +1000 [thread overview]
Message-ID: <20161220121412.213b9ca0@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <1482134828-18811-8-git-send-email-maddy@linux.vnet.ibm.com>
On Mon, 19 Dec 2016 13:37:03 +0530
Madhavan Srinivasan <maddy@linux.vnet.ibm.com> wrote:
> To support addition of "bitmask" to MASKABLE_* macros,
> factor out the EXCPETION_PROLOG_1 macro.
>
> Currently soft_enabled is used as the flag to determine
> the interrupt state. Patch extends the soft_enabled
> to be used as a mask instead of a flag.
This is really the core part of the patch -- after reversing the
soft_enable logic to be a disable boolean, now it's being extended
to be a disable mask. The exception macro changes just allow an
interrupt type bit to be passed in later.
I should have picked it up earlier, but if you do end up submitting
another version, perhaps consider splitting the disable mask change
and putting it after patch 5.
Thanks,
Nick
next prev parent reply other threads:[~2016-12-20 2:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 8:06 [PATCH v4 00/12]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2016-12-19 8:06 ` [PATCH v4 01/12] powerpc: Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2016-12-20 7:31 ` Balbir Singh
2016-12-21 3:22 ` Madhavan Srinivasan
2016-12-19 8:06 ` [PATCH v4 02/12] powerpc: move set_soft_enabled() and rename Madhavan Srinivasan
2016-12-20 9:03 ` Balbir Singh
2016-12-20 9:32 ` Benjamin Herrenschmidt
2016-12-20 13:58 ` Balbir Singh
2016-12-21 3:32 ` Madhavan Srinivasan
2016-12-19 8:06 ` [PATCH v4 03/12] powerpc: Use soft_enabled_set api to update paca->soft_enabled Madhavan Srinivasan
2016-12-19 8:07 ` [PATCH v4 04/12] powerpc: Add soft_enabled manipulation functions Madhavan Srinivasan
2016-12-19 8:07 ` [PATCH v4 05/12] powerpc: reverse the soft_enable logic Madhavan Srinivasan
2016-12-19 8:07 ` [PATCH v4 06/12] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2016-12-19 8:07 ` [PATCH v4 07/12] powerpc: Add support to take additional parameter in MASKABLE_* macro Madhavan Srinivasan
2016-12-20 2:36 ` Nicholas Piggin [this message]
2016-12-21 6:14 ` Madhavan Srinivasan
2016-12-19 8:07 ` [PATCH v4 08/12] powerpc: Add support to mask perf interrupts and replay them Madhavan Srinivasan
2016-12-19 8:07 ` [PATCH v4 09/12] powerpc:Add new kconfig IRQ_DEBUG_SUPPORT Madhavan Srinivasan
2016-12-19 8:07 ` [PATCH v4 10/12] powerpc: Add new set of soft_enabled_ functions Madhavan Srinivasan
2016-12-20 2:42 ` Nicholas Piggin
2016-12-19 8:07 ` [PATCH v4 11/12] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan
2016-12-19 8:07 ` [PATCH v4 12/12] powerpc: Rename soft_enabled to soft_disabled_mask Madhavan Srinivasan
2016-12-20 2:58 ` Nicholas Piggin
2017-01-04 9:33 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220121412.213b9ca0@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).