From: "Harisangam, Sharvari (S.)" <sharvari.harisangam@visteon.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Timur Tabi <timur@tabi.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
"Xiubo Li" <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode
Date: Wed, 28 Dec 2016 15:53:33 +0000 [thread overview]
Message-ID: <20161228155321.GA19963@ubuntu> (raw)
In-Reply-To: <87inq4f6pa.fsf@linux-m68k.org>
On Wed, Dec 28, 2016 at 03:50:57PM +0100, Andreas Schwab wrote:
> On Dez 28 2016, "Harisangam, Sharvari (S.)" <sharvari.harisangam@visteon.=
com> wrote:
>=20
> > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) =3D=3D
> > + SND_SOC_DAIFMT_AC97;
>=20
> This is never true.
>=20
> Andreas.
>=20
> --=20
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED=
5
> "And now for something completely different."
Ok. I missed the braces there. I will modify and resubmit the patch
-Thanks
Sharvari=
next prev parent reply other threads:[~2016-12-28 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 11:06 [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode Harisangam, Sharvari (S.)
2016-12-28 14:50 ` Andreas Schwab
2016-12-28 15:48 ` Timur Tabi
2016-12-28 15:53 ` Harisangam, Sharvari (S.) [this message]
[not found] ` <9ebb798c-6040-9262-9625-ddcebd05a188__32955.7460187518$1482940206$gmane$org@tabi.org>
2016-12-28 16:52 ` Andreas Schwab
2016-12-28 17:53 ` [alsa-devel] " Fabio Estevam
2017-01-04 12:22 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161228155321.GA19963@ubuntu \
--to=sharvari.harisangam@visteon.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=schwab@linux-m68k.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).