From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0135.outbound.protection.outlook.com [104.47.0.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tpchz6LHtzDq62 for ; Thu, 29 Dec 2016 02:53:39 +1100 (AEDT) From: "Harisangam, Sharvari (S.)" To: Andreas Schwab CC: Timur Tabi , Nicolin Chen , "Xiubo Li" , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode Date: Wed, 28 Dec 2016 15:53:33 +0000 Message-ID: <20161228155321.GA19963@ubuntu> References: <20161228110636.GA14768@ubuntu> <87inq4f6pa.fsf@linux-m68k.org> In-Reply-To: <87inq4f6pa.fsf@linux-m68k.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Dec 28, 2016 at 03:50:57PM +0100, Andreas Schwab wrote: > On Dez 28 2016, "Harisangam, Sharvari (S.)" wrote: >=20 > > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) =3D=3D > > + SND_SOC_DAIFMT_AC97; >=20 > This is never true. >=20 > Andreas. >=20 > --=20 > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 > "And now for something completely different." Ok. I missed the braces there. I will modify and resubmit the patch -Thanks Sharvari=