linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe LEROY <christophe.leroy@c-s.fr>
Cc: benh@au1.ibm.com, Christian Kujau <lists@nerdbynature.de>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: bootx_init.c:88: undefined reference to `__stack_chk_fail_local'
Date: Wed, 4 Jan 2017 02:40:03 -0600	[thread overview]
Message-ID: <20170104084003.GD28613@gate.crashing.org> (raw)
In-Reply-To: <ca802791-9a7d-90b4-2025-852517225f14@c-s.fr>

On Wed, Jan 04, 2017 at 09:23:47AM +0100, Christophe LEROY wrote:
> >The way gcc implements the stack protector has some serious
> >incompatibilities with the way the Linux kernel uses r13, I wouldn't
> >even try until we sort that out...
> 
> Yes indeed, it looks like recent versions of GCC don't use anymore the 
> global __stack_chk_guard variable but a hard coded offset relative to r2 
> or r13:
> 
> On 32 bits, it uses -7008(r2)
> On 64 bits, it uses -7010(r13)

This is https://gcc.gnu.org/PR78875 .  It should have been this way since
forever; if it really wasn't, it is unclear why not.

Either way, we (i.e. GCC) will add some compiler option to make this work
for the kernel.  It will be part of 7 and we'll probably backport it to
6.4 and 5.5 .

For bootx_init.c, this probably should be compiled with -fno-stack-protector
just like all the other boot time stuff.


Segher

  reply	other threads:[~2017-01-04  8:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 15:25 bootx_init.c:88: undefined reference to `__stack_chk_fail_local' Christian Kujau
2017-01-03 19:20 ` Christian Kujau
2017-01-03 22:50 ` Benjamin Herrenschmidt
2017-01-03 22:57   ` Christian Kujau
2017-01-04  8:23   ` Christophe LEROY
2017-01-04  8:40     ` Segher Boessenkool [this message]
2017-01-04  7:32 ` Christophe LEROY
2017-01-04 15:22   ` Christian Kujau
2017-01-04 18:33   ` Christian Kujau
2017-01-10  2:11     ` Christian Kujau
2017-01-10  4:32       ` Benjamin Herrenschmidt
2017-01-10  6:12         ` Christophe LEROY
2017-01-10 18:46         ` Christian Kujau
2017-01-10  6:26       ` Christophe LEROY
2017-01-11 22:54         ` Segher Boessenkool
2017-01-12  7:52           ` Christophe LEROY
2017-01-12 14:42             ` Christophe LEROY
2017-01-12 15:20               ` Benjamin Herrenschmidt
2017-01-12 18:07                 ` Segher Boessenkool
2017-01-13 12:15                   ` Christophe LEROY
2017-01-13 12:23                     ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170104084003.GD28613@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=benh@au1.ibm.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lists@nerdbynature.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).