From: Christoph Hellwig <hch@infradead.org>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Cc: axboe@kernel.dk, jack@suse.cz, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
anton@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] do_direct_IO: Use inode->i_blkbits to compute block count to be cleaned
Date: Mon, 9 Jan 2017 05:52:38 -0800 [thread overview]
Message-ID: <20170109135238.GA17003@infradead.org> (raw)
In-Reply-To: <1483886830-23878-1-git-send-email-chandan@linux.vnet.ibm.com>
On Sun, Jan 08, 2017 at 08:17:10PM +0530, Chandan Rajendra wrote:
> The code currently uses sdio->blkbits to compute the number of blocks to
> be cleaned. However sdio->blkbits is derived from the logical block size
> of the underlying block device (Refer to the definition of
> do_blockdev_direct_IO()). Due to this, generic/299 test would rarely
> fail when executed on an ext4 filesystem with 64k as the block size and
> when using a virtio based disk (having 512 byte as the logical block
> size) inside a kvm guest.
>
> This commit fixes the bug by using inode->i_blkbits to compute the
> number of blocks to be cleaned.
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-01-09 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 14:47 [PATCH] do_direct_IO: Use inode->i_blkbits to compute block count to be cleaned Chandan Rajendra
2017-01-09 13:52 ` Christoph Hellwig [this message]
2017-01-09 15:32 ` Jens Axboe
2017-01-09 16:04 ` Jeff Moyer
2017-01-09 20:20 ` Jan Kara
2017-01-09 21:42 ` [PATCH] direct-io: don't introduce another read of inode->i_blkbits Jeff Moyer
2017-01-09 21:44 ` Jens Axboe
2017-01-10 5:27 ` Chandan Rajendra
2017-01-10 20:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109135238.GA17003@infradead.org \
--to=hch@infradead.org \
--cc=anton@samba.org \
--cc=axboe@kernel.dk \
--cc=chandan@linux.vnet.ibm.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).