From: Nicholas Piggin <npiggin@gmail.com>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: benh@kernel.crashing.org, mpe@ellerman.id.au, anton@samba.org,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v6 12/12] powerpc: Rename soft_enabled to soft_disabled_mask
Date: Tue, 10 Jan 2017 16:02:06 +1000 [thread overview]
Message-ID: <20170110160206.27790628@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <1483968978-16035-13-git-send-email-maddy@linux.vnet.ibm.com>
On Mon, 9 Jan 2017 19:06:18 +0530
Madhavan Srinivasan <maddy@linux.vnet.ibm.com> wrote:
> Rename the paca->soft_enabled to paca->soft_disabled_mask as
> it is no more used as a flag for interrupt state.
>
> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> -static inline notrace void soft_enabled_set(unsigned long enable)
> +static inline notrace void soft_disabled_mask_set(unsigned long enable)
> -static inline notrace unsigned long soft_enabled_set_return(unsigned long enable)
> +static inline notrace unsigned long soft_disabled_mask_set_return(unsigned long enable)
> -static inline notrace unsigned long soft_enabled_or_return(unsigned long enable)
> +static inline notrace unsigned long soft_disabled_mask_or_return(unsigned long enable)
> @@ -228,11 +228,11 @@ notrace void arch_local_irq_restore(unsigned long en)
> unsigned int replay;
>
> #ifdef CONFIG_IRQ_DEBUG_SUPPORT
> - WARN_ON(en & local_paca->soft_enabled & ~IRQ_DISABLE_MASK_LINUX);
> + WARN_ON(en & local_paca->soft_disabled_mask & ~IRQ_DISABLE_MASK_LINUX);
> #endif
>
> /* Write the new soft-enabled value */
> - soft_enabled_set(en);
> + soft_disabled_mask_set(en);
>
Aside from a few minor instances of variable names and comments, this
looks good to me. Much easier to read.
I have no remaining issues with this series.
Thanks,
Nick
next prev parent reply other threads:[~2017-01-10 6:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 13:36 [PATCH v6 00/12]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 01/12] powerpc: Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 02/12] powerpc: move set_soft_enabled() and rename Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 03/12] powerpc: Use soft_enabled_set api to update paca->soft_enabled Madhavan Srinivasan
2017-01-10 5:48 ` Nicholas Piggin
2017-01-09 13:36 ` [PATCH v6 04/12] powerpc: Add soft_enabled manipulation functions Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 05/12] powerpc: reverse the soft_enable logic Madhavan Srinivasan
2017-01-10 5:52 ` Nicholas Piggin
2017-01-09 13:36 ` [PATCH v6 06/12] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 07/12] Add support to take additional parameter in MASKABLE_* macro Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 08/12] powerpc: Add support to mask perf interrupts and replay them Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 09/12] powerpc:Add new kconfig IRQ_DEBUG_SUPPORT Madhavan Srinivasan
2017-01-10 5:54 ` Nicholas Piggin
2017-01-09 13:36 ` [PATCH v6 10/12] powerpc: Add new set of soft_enabled_ functions Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 11/12] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan
2017-01-09 13:36 ` [PATCH v6 12/12] powerpc: Rename soft_enabled to soft_disabled_mask Madhavan Srinivasan
2017-01-10 6:02 ` Nicholas Piggin [this message]
2017-02-07 4:22 ` [PATCH v6 00/12]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2017-02-08 12:44 ` Michael Ellerman
2017-02-15 9:36 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110160206.27790628@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).