From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net (unknown [184.105.139.130]) by lists.ozlabs.org (Postfix) with ESMTP id 3v7KDz6htfzDqBZ for ; Wed, 25 Jan 2017 07:15:45 +1100 (AEDT) Date: Tue, 24 Jan 2017 15:15:33 -0500 (EST) Message-Id: <20170124.151533.1564753892669791067.davem@davemloft.net> To: thuth@redhat.com Cc: tlfalcon@linux.vnet.ibm.com, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] ibmveth: Add a proper check for the availability of the checksum features From: David Miller In-Reply-To: <1485239321-14947-1-git-send-email-thuth@redhat.com> References: <1485239321-14947-1-git-send-email-thuth@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Huth Date: Tue, 24 Jan 2017 07:28:41 +0100 > When using the ibmveth driver in a KVM/QEMU based VM, it currently > always prints out a scary error message like this when it is started: > > ibmveth 71000003 (unregistered net_device): unable to change > checksum offload settings. 1 rc=-2 ret_attr=71000003 > > This happens because the driver always tries to enable the checksum > offloading without checking for the availability of this feature first. > QEMU does not support checksum offloading for the spapr-vlan device, > thus we always get the error message here. > According to the LoPAPR specification, the "ibm,illan-options" property > of the corresponding device tree node should be checked first to see > whether the H_ILLAN_ATTRIUBTES hypercall and thus the checksum offloading > feature is available. Thus let's do this in the ibmveth driver, too, so > that the error message is really only limited to cases where something > goes wrong, and does not occur if the feature is just missing. > > Signed-off-by: Thomas Huth Applied.