From: Paul Mackerras <paulus@ozlabs.org>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Alexander Graf <agraf@suse.com>
Subject: Re: [PATCH] KVM: PPC: Book3S PR: Refactor program interrupt related code into separate function
Date: Fri, 27 Jan 2017 20:46:59 +1100 [thread overview]
Message-ID: <20170127094659.GB17935@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <1485347242-4692-1-git-send-email-thuth@redhat.com>
On Wed, Jan 25, 2017 at 01:27:22PM +0100, Thomas Huth wrote:
> The function kvmppc_handle_exit_pr() is quite huge and thus hard to read,
> and even contains a "spaghetti-code"-like goto between the different case
> labels of the big switch statement. This can be made much more readable
> by moving the code related to injecting program interrupts / instruction
> emulation into a separate function instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to my kvm-ppc-next branch.
Paul.
prev parent reply other threads:[~2017-01-27 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 12:27 [PATCH] KVM: PPC: Book3S PR: Refactor program interrupt related code into separate function Thomas Huth
2017-01-27 9:46 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127094659.GB17935@fergus.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=agraf@suse.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).