linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: fweisbec@gmail.com, tglx@linutronix.de, pmladek@suse.com,
	hpa@zytor.com, efault@gmx.de, sergey.senozhatsky.work@gmail.com,
	peterz@infradead.org, mgorman@techsingularity.net,
	wanpeng.li@hotmail.com, umgwanakikbuti@gmail.com,
	byungchul.park@lge.com, jack@suse.cz, mingo@kernel.org,
	riel@redhat.com, luca.abeni@unitn.it, yuyang.du@intel.com,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-tip-commits@vger.kernel.org,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [tip:sched/core] sched/core: Add debugging code to catch missing update_rq_clock() calls
Date: Mon, 30 Jan 2017 21:34:35 +0000	[thread overview]
Message-ID: <20170130213435.GM31613@codeblueprint.co.uk> (raw)
In-Reply-To: <87tw8gutp6.fsf@concordia.ellerman.id.au>

On Tue, 31 Jan, at 08:24:53AM, Michael Ellerman wrote:
> 
> I'm hitting this on multiple powerpc systems:
> 
> [   38.339126] rq->clock_update_flags < RQCF_ACT_SKIP
> [   38.339134] ------------[ cut here ]------------
> [   38.339142] WARNING: CPU: 2 PID: 1 at kernel/sched/sched.h:804 detach_task_cfs_rq+0xa0c/0xd10

[...]
 
> I assume I should be worried?

Thanks for the report. No need to worry, the bug has existed for a
while, this patch just turns on the warning ;-)

The following commit queued up in tip/sched/core should fix your
issues (assuming you see the same callstack on all your powerpc
machines):

  https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=sched/core&id=1b1d62254df0fe42a711eb71948f915918987790

  reply	other threads:[~2017-01-30 21:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160921133813.31976-8-matt@codeblueprint.co.uk>
     [not found] ` <tip-cb42c9a3ebbbb23448c3f9a25417fae6309b1a92@git.kernel.org>
2017-01-30 21:24   ` [tip:sched/core] sched/core: Add debugging code to catch missing update_rq_clock() calls Michael Ellerman
2017-01-30 21:34     ` Matt Fleming [this message]
2017-01-31  8:35       ` Michael Ellerman
2017-01-31 11:00       ` Sachin Sant
2017-01-31 11:48         ` Mike Galbraith
2017-01-31 17:22           ` Ross Zwisler
2017-02-02 15:55             ` Peter Zijlstra
2017-02-02 22:01               ` Matt Fleming
2017-02-03  3:05               ` Mike Galbraith
2017-02-03  4:33               ` Sachin Sant
2017-02-03  8:53                 ` Peter Zijlstra
2017-02-03 11:04                   ` Sachin Sant
2017-02-03 12:59                   ` Mike Galbraith
2017-02-03 13:37                     ` Peter Zijlstra
2017-02-03 13:52                       ` Mike Galbraith
2017-02-03 15:44                       ` Paul E. McKenney
2017-02-03 15:54                         ` Paul E. McKenney
2017-02-06  6:23                           ` Sachin Sant
2017-02-06 15:10                             ` Paul E. McKenney
2017-02-06 15:14                               ` Paul E. McKenney
2017-02-03 13:04               ` Borislav Petkov
2017-02-22  9:03               ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170130213435.GM31613@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=byungchul.park@lge.com \
    --cc=efault@gmx.de \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luca.abeni@unitn.it \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=riel@redhat.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=umgwanakikbuti@gmail.com \
    --cc=wanpeng.li@hotmail.com \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).