From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
linux-kernel@vger.kernel.org, Scott Wood <oss@buserror.net>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH RFC] powerpc/32: fix handling of stack protector with recent GCC
Date: Mon, 30 Jan 2017 19:22:33 -0600 [thread overview]
Message-ID: <20170131012233.GC21840@gate.crashing.org> (raw)
In-Reply-To: <alpine.DEB.2.20.999.1701301611590.3270@trent.utfs.org>
On Mon, Jan 30, 2017 at 04:12:53PM -0800, Christian Kujau wrote:
> On Mon, 16 Jan 2017, Christophe Leroy wrote:
> > Since 2005, powerpc GCC doesn't manage anymore __stack_chk_guard as
> > a global variable but as some value located at -0x7008(r2)
>
> Is this still an "RFC" or is there a chance that this will land in 4.10?
Older GCC (i.e. not ancient, but < 7 currently; the new options will be
backported to 5 and 6) doesn't always use TLS stack canaries either: it
depends on how your GCC is configured. The kernel will have to detect
if the GCC it uses knows the new options, and if not, if it still wants
to use SSP it has to detect what GCC uses to get at the canary.
This patch as-is won't work.
Segher
next prev parent reply other threads:[~2017-01-31 1:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 9:00 [PATCH RFC] powerpc/32: fix handling of stack protector with recent GCC Christophe Leroy
2017-01-19 3:36 ` Christian Kujau
2017-01-31 0:12 ` Christian Kujau
2017-01-31 1:22 ` Segher Boessenkool [this message]
2017-01-31 3:37 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131012233.GC21840@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lists@nerdbynature.de \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).