From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au
Subject: Re: [PATCH] powerpc/mm: Fix typo in set_pte_at()
Date: Mon, 6 Feb 2017 15:51:31 +1100 [thread overview]
Message-ID: <20170206045131.GA22716@gwshan> (raw)
In-Reply-To: <87tw88gi96.fsf@skywalker.in.ibm.com>
On Mon, Feb 06, 2017 at 08:03:57AM +0530, Aneesh Kumar K.V wrote:
>Gavin Shan <gwshan@linux.vnet.ibm.com> writes:
>
>> This fixes the typo about the _PAGE_PTE in set_pte_at() by changing
>> "tryint" to "trying to".
>>
>> Fixes: 6a119eae942 ("powerpc/mm: Add a _PAGE_PTE bit")
>
>I guess this is not needed. We add that when we want to hint whether the
>patch needs backporting.
>
Thanks for review. I used the tag to indicate the commit introducing
the typo. For this trivial patch, we won't backport it to table or
distro. If you want, I can drop the tag or Michael helps to drop it
when merging it.
Thanks,
Gavin
>
>> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> ---
>> arch/powerpc/mm/pgtable.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
>> index cb39c8b..a03ff3d 100644
>> --- a/arch/powerpc/mm/pgtable.c
>> +++ b/arch/powerpc/mm/pgtable.c
>> @@ -193,9 +193,7 @@ void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep,
>> */
>> VM_WARN_ON(pte_present(*ptep) && !pte_protnone(*ptep));
>>
>> - /*
>> - * Add the pte bit when tryint set a pte
>> - */
>> + /* Add the pte bit when trying to set a pte */
>> pte = __pte(pte_val(pte) | _PAGE_PTE);
>>
>> /* Note: mm->context.id might not yet have been assigned as
>> --
>> 2.7.4
next prev parent reply other threads:[~2017-02-06 4:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 0:19 [PATCH] powerpc/mm: Fix typo in set_pte_at() Gavin Shan
2017-02-06 2:33 ` Aneesh Kumar K.V
2017-02-06 4:51 ` Gavin Shan [this message]
2017-02-08 3:17 ` Gavin Shan
2017-02-08 9:22 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206045131.GA22716@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).