linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
	Oliver O'Halloran <oohall@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error
Date: Thu, 23 Feb 2017 05:01:43 +0100	[thread overview]
Message-ID: <20170223040142.GA5323@lerouge> (raw)
In-Reply-To: <87fuj5zz8o.fsf@concordia.ellerman.id.au>

On Thu, Feb 23, 2017 at 08:34:15AM +1100, Michael Ellerman wrote:
> Frederic Weisbecker <fweisbec@gmail.com> writes:
> 
> > This type conversion is a leftover that got ignored during the kcpustat
> > conversion to nanosecs, resulting in build breakage with config having
> > CONFIG_NO_HZ_FULL=y.
> >
> > 	arch/powerpc/kernel/time.c: In function 'running_clock':
> > 	arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function 'cputime_to_nsecs' [-Werror=implicit-function-declaration]
> > 	  return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
> >
> > All we need is to remove it.
> >
> > Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Oliver O'Halloran <oohall@gmail.com>
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> 
> LGTM.
> 
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> 
> 
> Are you going to send this to Linus, or should I?

I would prefer you send it to Linus if you don't mind.

The fate of a powerpc patch sent by me directly to Linus is
anything but predictable :o)

Thanks.

  reply	other threads:[~2017-02-23  4:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 15:18 [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error Frederic Weisbecker
2017-02-22 21:34 ` Michael Ellerman
2017-02-23  4:01   ` Frederic Weisbecker [this message]
2017-02-27 10:11 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223040142.GA5323@lerouge \
    --to=fweisbec@gmail.com \
    --cc=abdhalee@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=oohall@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).