From: Nicholas Piggin <npiggin@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] powerpc/pasemi,cbe: Do not process decremeter or external wakeup from powersave
Date: Fri, 17 Mar 2017 17:48:15 +1000 [thread overview]
Message-ID: <20170317174815.3e9686e2@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <87r31wbfes.fsf@concordia.ellerman.id.au>
On Fri, 17 Mar 2017 17:12:11 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:
> Michael Ellerman <mpe@ellerman.id.au> writes:
>
> > Nicholas Piggin <npiggin@gmail.com> writes:
> >
> >> Hi,
> >>
> >> I would like to start using a dedicated stack for system reset interrupt
> >> and treat it as a Linux nmi, which makes it tricky to call complex
> >> interrupt handlers directly from the system reset trap handler.
> >>
> >> So I would like to remove the decrementer and external handler calls from
> >> Cell and Pasemi platforms' system reset handler. I think we can just
> >> remove them if they can be handled when they re-fire as normal interrupts?
> >> At the moment I don't have environments set up to test if this works.
> >
> > My QS22 has booted OK with it applied, so it seems OK.
> >
> > I'll test it a bit more tomorrow.
>
> OK, seems fine, and I have a trace that shows it's definitely going
> through that path:
Thanks for testing it.
> 1) | .default_idle_call() {
> 1) | .arch_cpu_idle() {
> 1) | .cbe_power_save() {
> 1) 0.128 us | .prep_irq_for_idle();
> 1) | .system_reset_exception() {
> 1) 0.512 us | .cbe_system_reset_exception();
> 1) 6.016 us | }
> 1) | .do_IRQ() {
It seems to do the right thing. I think decrementer should be working
proprely by setting it to 1 to get another exception?
In that case I will add a changelog and submit the patch.
Thanks,
Nick
next prev parent reply other threads:[~2017-03-17 7:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 15:43 [PATCH] powerpc/pasemi, cbe: Do not process decremeter or external wakeup from powersave Nicholas Piggin
2017-03-16 10:31 ` Michael Ellerman
2017-03-17 6:12 ` Michael Ellerman
2017-03-17 7:48 ` Nicholas Piggin [this message]
2017-03-17 10:17 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2017-03-17 14:43 Christian Zigotzky
2017-03-18 12:46 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317174815.3e9686e2@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).