From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: Daniel Baluta <daniel.baluta@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
<alsa-devel@alsa-project.org>, Timur Tabi <timur@tabi.org>,
<Xiubo.Lee@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, <fabio.estevam@nxp.com>,
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup
Date: Tue, 28 Mar 2017 16:42:38 +0100 [thread overview]
Message-ID: <20170328154238.GS6986@localhost.localdomain> (raw)
In-Reply-To: <20170328152457.2j5zaxdbdavpuspa@sirena.org.uk>
On Tue, Mar 28, 2017 at 04:24:57PM +0100, Mark Brown wrote:
> On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote:
> > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote:
>
> > > >> - codec_clk = devm_clk_get(&codec_dev->dev, NULL);
> > > >> + codec_clk = clk_get(&codec_dev->dev, NULL);
>
> > > is different from &codec_dev->dev.
>
> > I get that they are different, I just don't get why changing
> > from a devm_clk_get to a clk_get is a better fix than changing
> > &codec->dev to &pdev->dev.
>
> This should be clear from the semantics of clk_get(): you're looking up
> the clock in the context of the supplied device and the clock is
> attached to the CODEC so you need to look up in the CODEC context. What
> would be even better would be to move the allocation of the clock into
> the CODEC driver...
Ah yes thats what I was missing.
Thanks,
Charles
next prev parent reply other threads:[~2017-03-28 15:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:58 [PATCH v3 0/2] imx-wm8962: Let codec driver enable/disable its MCLK Daniel Baluta
2017-03-28 8:58 ` [PATCH v3 1/2] ASoC: " Daniel Baluta
2017-03-28 8:58 ` [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Daniel Baluta
2017-03-28 9:21 ` [alsa-devel] " Charles Keepax
2017-03-28 10:47 ` Daniel Baluta
2017-03-28 11:53 ` Charles Keepax
2017-03-28 15:24 ` Mark Brown
2017-03-28 15:42 ` Charles Keepax [this message]
2017-03-29 11:38 ` Daniel Baluta
2017-03-29 11:47 ` Mark Brown
2017-03-29 11:54 ` Applied "ASoC: imx-wm8962: Fix codec_clk cleanup" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328154238.GS6986@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).