From: Nicholas Piggin <npiggin@gmail.com>
To: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH 2/2] powerpc/book3s: Display task info for MCE error in user mode.
Date: Thu, 30 Mar 2017 10:09:47 +1000 [thread overview]
Message-ID: <20170330100947.74c7a76d@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <149070872807.18309.16273606222489045198.stgit@jupiter.in.ibm.com>
On Tue, 28 Mar 2017 19:15:28 +0530
Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> wrote:
> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>
> For MCE that hit while in use mode MSR(HV=1,PR=1), print the task info on the
> console MCE error log. This will help to identify application that stumbled
> upon MCE error.
I think you may still want these details for a task currently in
kernel. How about something like if (!in_interrupt()) {
> @@ -311,8 +312,13 @@ void machine_check_print_event_info(struct machine_check_event *evt)
> printk("%s%s Machine check interrupt [%s]\n", level, sevstr,
> evt->disposition == MCE_DISPOSITION_RECOVERED ?
> "Recovered" : "Not recovered");
> - printk("%s NIP [%016llx]: %pS\n", level, evt->srr0,
> + if (user_mode) {
> + printk("%s NIP: [%016llx] PID: %d Comm: %s\n", level,
> + evt->srr0, current->pid, current->comm);
> + } else {
> + printk("%s NIP [%016llx]: %pS\n", level, evt->srr0,
> (void *)evt->srr0);
> + }
> printk("%s Initiator: %s\n", level,
> evt->initiator == MCE_INITIATOR_CPU ? "CPU" : "Unknown");
> switch (evt->error_type) {
next prev parent reply other threads:[~2017-03-30 0:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 13:45 [PATCH 1/2] powerpc/book3s: Display more info for MCE error console log Mahesh J Salgaonkar
2017-03-28 13:45 ` [PATCH 2/2] powerpc/book3s: Display task info for MCE error in user mode Mahesh J Salgaonkar
2017-03-30 0:09 ` Nicholas Piggin [this message]
2017-03-30 7:04 ` Mahesh Jagannath Salgaonkar
2017-04-06 13:06 ` [1/2] powerpc/book3s: Display more info for MCE error console log Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330100947.74c7a76d@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).