* [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
@ 2017-04-02 10:05 Pavel Machek
2017-05-17 12:06 ` Pavel Machek
2017-05-30 9:11 ` Michael Ellerman
0 siblings, 2 replies; 10+ messages in thread
From: Pavel Machek @ 2017-04-02 10:05 UTC (permalink / raw)
To: sr, jwboyer, robh+dt, mark.rutland, benh, paulus, mpe, devicetree,
linuxppc-dev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
Fix overlapping NAND partitions.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/arch/powerpc/boot/dts/sequoia.dts b/arch/powerpc/boot/dts/sequoia.dts
index b1d3292..e41b88a 100644
--- a/arch/powerpc/boot/dts/sequoia.dts
+++ b/arch/powerpc/boot/dts/sequoia.dts
@@ -229,7 +229,7 @@
};
partition@84000 {
label = "user";
- reg = <0x00000000 0x01f7c000>;
+ reg = <0x00084000 0x01f7c000>;
};
};
};
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-04-02 10:05 [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek
@ 2017-05-17 12:06 ` Pavel Machek
2017-05-17 21:37 ` Andrew Morton
2017-05-30 9:11 ` Michael Ellerman
1 sibling, 1 reply; 10+ messages in thread
From: Pavel Machek @ 2017-05-17 12:06 UTC (permalink / raw)
To: sr, jwboyer, robh+dt, mark.rutland, benh, paulus, mpe, devicetree,
linuxppc-dev, linux-kernel
Cc: trivial, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
> Fix overlapping NAND partitions.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
Ping? Two partitions at same place are bad news...
Pavel
> diff --git a/arch/powerpc/boot/dts/sequoia.dts b/arch/powerpc/boot/dts/sequoia.dts
> index b1d3292..e41b88a 100644
> --- a/arch/powerpc/boot/dts/sequoia.dts
> +++ b/arch/powerpc/boot/dts/sequoia.dts
> @@ -229,7 +229,7 @@
> };
> partition@84000 {
> label = "user";
> - reg = <0x00000000 0x01f7c000>;
> + reg = <0x00084000 0x01f7c000>;
> };
> };
> };
>
>
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-17 12:06 ` Pavel Machek
@ 2017-05-17 21:37 ` Andrew Morton
2017-05-18 9:48 ` Pavel Machek
0 siblings, 1 reply; 10+ messages in thread
From: Andrew Morton @ 2017-05-17 21:37 UTC (permalink / raw)
To: Pavel Machek
Cc: sr, jwboyer, robh+dt, mark.rutland, benh, paulus, mpe, devicetree,
linuxppc-dev, linux-kernel, trivial, Andrew Morton
On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
> On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
> > Fix overlapping NAND partitions.
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> Ping? Two partitions at same place are bad news...
Please expand on "bad news"? What are the runtime effects of this
change? Decisions about which kernel(s) to patch depend on this info.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-17 21:37 ` Andrew Morton
@ 2017-05-18 9:48 ` Pavel Machek
2017-05-19 5:50 ` Michael Ellerman
0 siblings, 1 reply; 10+ messages in thread
From: Pavel Machek @ 2017-05-18 9:48 UTC (permalink / raw)
To: Andrew Morton
Cc: sr, jwboyer, robh+dt, mark.rutland, benh, paulus, mpe, devicetree,
linuxppc-dev, linux-kernel, trivial, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
>
> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
> > > Fix overlapping NAND partitions.
> > >
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> >
> > Ping? Two partitions at same place are bad news...
>
> Please expand on "bad news"? What are the runtime effects of this
> change? Decisions about which kernel(s) to patch depend on this info.
Well... two partitions at same place. If you use one, you will corrupt
information on the other one.
OTOH this moves partition around (so that they don't overlap) so it is
probably not stable candidate.
I guess this is not huge issue; people using these boards probably
have custom dts changes, anyway...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-18 9:48 ` Pavel Machek
@ 2017-05-19 5:50 ` Michael Ellerman
2017-05-19 9:12 ` Pavel Machek
2017-05-19 10:04 ` Michael Ellerman
0 siblings, 2 replies; 10+ messages in thread
From: Michael Ellerman @ 2017-05-19 5:50 UTC (permalink / raw)
To: Pavel Machek, Andrew Morton
Cc: sr, jwboyer, robh+dt, mark.rutland, benh, paulus, devicetree,
linuxppc-dev, linux-kernel, trivial, Andrew Morton
Pavel Machek <pavel@denx.de> writes:
> On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
>>
>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
>> > > Fix overlapping NAND partitions.
>> > >
>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>> >
>> > Ping? Two partitions at same place are bad news...
>>
>> Please expand on "bad news"? What are the runtime effects of this
>> change? Decisions about which kernel(s) to patch depend on this info.
>
> Well... two partitions at same place. If you use one, you will corrupt
> information on the other one.
>
> OTOH this moves partition around (so that they don't overlap) so it is
> probably not stable candidate.
>
> I guess this is not huge issue; people using these boards probably
> have custom dts changes, anyway...
Or no one's even using it anymore.
I can take this via powerpc, I won't mark it for stable etc.
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-19 5:50 ` Michael Ellerman
@ 2017-05-19 9:12 ` Pavel Machek
2017-05-19 10:04 ` Michael Ellerman
1 sibling, 0 replies; 10+ messages in thread
From: Pavel Machek @ 2017-05-19 9:12 UTC (permalink / raw)
To: Michael Ellerman
Cc: Andrew Morton, sr, jwboyer, robh+dt, mark.rutland, benh, paulus,
devicetree, linuxppc-dev, linux-kernel, trivial, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
Hi!
> > Well... two partitions at same place. If you use one, you will corrupt
> > information on the other one.
> >
> > OTOH this moves partition around (so that they don't overlap) so it is
> > probably not stable candidate.
> >
> > I guess this is not huge issue; people using these boards probably
> > have custom dts changes, anyway...
>
> Or no one's even using it anymore.
>
> I can take this via powerpc, I won't mark it for stable etc.
That sounds good.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-19 5:50 ` Michael Ellerman
2017-05-19 9:12 ` Pavel Machek
@ 2017-05-19 10:04 ` Michael Ellerman
2017-05-19 11:18 ` Pavel Machek
1 sibling, 1 reply; 10+ messages in thread
From: Michael Ellerman @ 2017-05-19 10:04 UTC (permalink / raw)
To: Pavel Machek, Andrew Morton
Cc: mark.rutland, devicetree, trivial, linux-kernel, robh+dt, paulus,
Andrew Morton, jwboyer, sr, linuxppc-dev
Michael Ellerman <mpe@ellerman.id.au> writes:
> Pavel Machek <pavel@denx.de> writes:
>
>> On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
>>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
>>>
>>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
>>> > > Fix overlapping NAND partitions.
>>> > >
>>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>> >
>>> > Ping? Two partitions at same place are bad news...
>>>
>>> Please expand on "bad news"? What are the runtime effects of this
>>> change? Decisions about which kernel(s) to patch depend on this info.
>>
>> Well... two partitions at same place. If you use one, you will corrupt
>> information on the other one.
>>
>> OTOH this moves partition around (so that they don't overlap) so it is
>> probably not stable candidate.
>>
>> I guess this is not huge issue; people using these boards probably
>> have custom dts changes, anyway...
>
> Or no one's even using it anymore.
>
> I can take this via powerpc, I won't mark it for stable etc.
It became:
Author: Pavel Machek <pavel@denx.de>
powerpc/sequoia: Fix NAND partitions not to overlap
Currently the DTS defines two partitions at the same addresses, if you
use one, you will corrupt information on the other one. Fix it by
shifting the second partition.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
[mpe: Reconstruct change log from email thread]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Minor nit, your From: address doesn't match your Signed-off-by: address,
which trips my "check patch is signed-off-by author" script. I can
just ignore it, but I think it's preferable if they match.
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-19 10:04 ` Michael Ellerman
@ 2017-05-19 11:18 ` Pavel Machek
2017-05-22 9:12 ` Michael Ellerman
0 siblings, 1 reply; 10+ messages in thread
From: Pavel Machek @ 2017-05-19 11:18 UTC (permalink / raw)
To: Michael Ellerman
Cc: Andrew Morton, mark.rutland, devicetree, trivial, linux-kernel,
robh+dt, paulus, Andrew Morton, jwboyer, sr, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]
Hi!
> >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> >>> >
> >>> > Ping? Two partitions at same place are bad news...
> >>>
> >>> Please expand on "bad news"? What are the runtime effects of this
> >>> change? Decisions about which kernel(s) to patch depend on this info.
> >>
> >> Well... two partitions at same place. If you use one, you will corrupt
> >> information on the other one.
> >>
> >> OTOH this moves partition around (so that they don't overlap) so it is
> >> probably not stable candidate.
> >>
> >> I guess this is not huge issue; people using these boards probably
> >> have custom dts changes, anyway...
> >
> > Or no one's even using it anymore.
> >
> > I can take this via powerpc, I won't mark it for stable etc.
>
> It became:
>
> Author: Pavel Machek <pavel@denx.de>
>
> powerpc/sequoia: Fix NAND partitions not to overlap
>
> Currently the DTS defines two partitions at the same addresses, if you
> use one, you will corrupt information on the other one. Fix it by
> shifting the second partition.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> [mpe: Reconstruct change log from email thread]
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
>
> Minor nit, your From: address doesn't match your Signed-off-by: address,
> which trips my "check patch is signed-off-by author" script. I can
> just ignore it, but I think it's preferable if they match.
Sorry about that (I have automatic scripts changing From:). It is
still me, but I guess denx should get the credit here, so you can use.
Signed-off-by: Pavel Machek <pavel@denx.de>
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-19 11:18 ` Pavel Machek
@ 2017-05-22 9:12 ` Michael Ellerman
0 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2017-05-22 9:12 UTC (permalink / raw)
To: Pavel Machek
Cc: Andrew Morton, mark.rutland, devicetree, trivial, linux-kernel,
robh+dt, paulus, Andrew Morton, jwboyer, sr, linuxppc-dev
Pavel Machek <pavel@denx.de> writes:
> Hi!
>
>> >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>> >>> >
>> >>> > Ping? Two partitions at same place are bad news...
>> >>>
>> >>> Please expand on "bad news"? What are the runtime effects of this
>> >>> change? Decisions about which kernel(s) to patch depend on this info.
>> >>
>> >> Well... two partitions at same place. If you use one, you will corrupt
>> >> information on the other one.
>> >>
>> >> OTOH this moves partition around (so that they don't overlap) so it is
>> >> probably not stable candidate.
>> >>
>> >> I guess this is not huge issue; people using these boards probably
>> >> have custom dts changes, anyway...
>> >
>> > Or no one's even using it anymore.
>> >
>> > I can take this via powerpc, I won't mark it for stable etc.
>>
>> It became:
>>
>> Author: Pavel Machek <pavel@denx.de>
>>
>> powerpc/sequoia: Fix NAND partitions not to overlap
>>
>> Currently the DTS defines two partitions at the same addresses, if you
>> use one, you will corrupt information on the other one. Fix it by
>> shifting the second partition.
>>
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>> [mpe: Reconstruct change log from email thread]
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>>
>>
>> Minor nit, your From: address doesn't match your Signed-off-by: address,
>> which trips my "check patch is signed-off-by author" script. I can
>> just ignore it, but I think it's preferable if they match.
>
> Sorry about that (I have automatic scripts changing From:). It is
> still me, but I guess denx should get the credit here, so you can use.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
Sure, done.
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: powerpc/sequoia: fix NAND partitions not to overlap
2017-04-02 10:05 [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek
2017-05-17 12:06 ` Pavel Machek
@ 2017-05-30 9:11 ` Michael Ellerman
1 sibling, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2017-05-30 9:11 UTC (permalink / raw)
To: Pavel Machek, sr, jwboyer, robh+dt, mark.rutland, benh, paulus,
devicetree, linuxppc-dev, linux-kernel
On Sun, 2017-04-02 at 10:05:36 UTC, Pavel Machek wrote:
> Fix overlapping NAND partitions.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/70a92003de599ff2f15815b3d9c445
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-05-30 9:11 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-02 10:05 [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek
2017-05-17 12:06 ` Pavel Machek
2017-05-17 21:37 ` Andrew Morton
2017-05-18 9:48 ` Pavel Machek
2017-05-19 5:50 ` Michael Ellerman
2017-05-19 9:12 ` Pavel Machek
2017-05-19 10:04 ` Michael Ellerman
2017-05-19 11:18 ` Pavel Machek
2017-05-22 9:12 ` Michael Ellerman
2017-05-30 9:11 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).