From: Nicholas Piggin <npiggin@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH 1/5] powerpc/pseries: do not use msgsndp doorbells on POWER9 guests
Date: Mon, 10 Apr 2017 14:28:42 +1000 [thread overview]
Message-ID: <20170410142842.1a41ffab@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <1491797258.4166.205.camel@kernel.crashing.org>
On Mon, 10 Apr 2017 14:07:38 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Mon, 2017-04-10 at 13:22 +1000, Nicholas Piggin wrote:
> > On Sun, 09 Apr 2017 18:03:35 +1000
> > > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > On Fri, 2017-04-07 at 22:55 +1000, Nicholas Piggin wrote:
> > > > POWER9 hypervisors will not necessarily run guest threads together on
> > > > the same core at the same time, so msgsndp should not be used.
> > >
> > > Maybe we shouldn't advertise doorbells at all ?
> >
> > Possibly not. I don't know if there is a good way to switch it off
> > in the guest from the host with device tree currently. Might be better
> > to clear it early in the guest rather than test it here though?
>
> Sure for now. Long term a separate DT entry would be good.
cpufeatures will do that, but I wonder if some hypervisors won't implement
that binding then might be worth getting into an existing one in PAPR.
Anyway for now I'll make the change and have P9 guest clear the feature
themselves if you like.
> Might be
> worth re-enabling one day if we have HW virtualization of geust
> doorbells.
Yes. Also some hypervisor might run in a virtual sibling = physical
sibling mode on P9 too where it could still work.
Thanks,
Nick
next prev parent reply other threads:[~2017-04-10 4:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 12:55 [PATCH 0/5] doorbell patches for POWER9 Nicholas Piggin
2017-04-07 12:55 ` [PATCH 1/5] powerpc/pseries: do not use msgsndp doorbells on POWER9 guests Nicholas Piggin
2017-04-09 8:03 ` Benjamin Herrenschmidt
2017-04-10 3:22 ` Nicholas Piggin
2017-04-10 4:07 ` Benjamin Herrenschmidt
2017-04-10 4:28 ` Nicholas Piggin [this message]
2017-04-11 10:10 ` Michael Ellerman
2017-04-11 12:18 ` Nicholas Piggin
2017-04-07 12:55 ` [PATCH 2/5] powerpc: change the doorbell IPI calling convention Nicholas Piggin
2017-04-07 12:56 ` [PATCH 3/5] powerpc: Introduce msgsnd/doorbell barrier primitives Nicholas Piggin
2017-04-07 12:56 ` [PATCH 4/5] powerpc/64s: avoid branch for ppc_msgsnd Nicholas Piggin
2017-04-07 12:56 ` [PATCH 5/5] powerpc/powernv: POWER9 support for msgsnd/doorbell IPI Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410142842.1a41ffab@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).