From: Jiri Olsa <jolsa@redhat.com>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 0/5] perf report: Show branch type
Date: Wed, 12 Apr 2017 17:46:59 +0200 [thread overview]
Message-ID: <20170412154659.GA30277@krava> (raw)
In-Reply-To: <9bbb8cc8-30d4-49b4-771b-fb529024aa98@linux.intel.com>
On Wed, Apr 12, 2017 at 11:42:44PM +0800, Jin, Yao wrote:
>
>
> On 4/12/2017 10:26 PM, Jiri Olsa wrote:
> > On Wed, Apr 12, 2017 at 08:25:34PM +0800, Jin, Yao wrote:
> >
> > SNIP
> >
> > > > # Overhead Command Source Shared Object Source Symbol Target Symbol Basic Block Cycles
> > > > # ........ ....... .................... ....................................... ....................................... ..................
> > > > #
> > > > 8.30% perf
> > > > Um [kernel.vmlinux] [k] __intel_pmu_enable_all.constprop.17 [k] native_write_msr -
> > > > 7.91% perf
> > > > Um [kernel.vmlinux] [k] intel_pmu_lbr_enable_all [k] __intel_pmu_enable_all.constprop.17 -
> > > > 7.91% perf
> > > > Um [kernel.vmlinux] [k] native_write_msr [k] intel_pmu_lbr_enable_all -
> > > > 6.32% kill libc-2.24.so [.] _dl_addr [.] _dl_addr -
> > > > 5.93% perf
> > > > Um [kernel.vmlinux] [k] perf_iterate_ctx [k] perf_iterate_ctx -
> > > > 2.77% kill libc-2.24.so [.] malloc [.] malloc -
> > > > 1.98% kill libc-2.24.so [.] _int_malloc [.] _int_malloc -
> > > > 1.58% kill [kernel.vmlinux] [k] __rb_insert_augmented [k] __rb_insert_augmented -
> > > > 1.58% perf
> > > > Um [kernel.vmlinux] [k] perf_event_exec [k] perf_event_exec -
> > > > 1.19% kill [kernel.vmlinux] [k] anon_vma_interval_tree_insert [k] anon_vma_interval_tree_insert -
> > > > 1.19% kill [kernel.vmlinux] [k] free_pgd_range [k] free_pgd_range -
> > > > 1.19% kill [kernel.vmlinux] [k] n_tty_write [k] n_tty_write -
> > > > 1.19% perf
> > > > Um [kernel.vmlinux] [k] native_sched_clock [k] sched_clock -
> > > > ...
> > > > SNIP
> > > >
> > > >
> > > > jirka
> > > Hi,
> > >
> > > Thanks so much for trying this patch.
> > >
> > > The branch statistics is printed at the end of perf report --stdio.
> > yep, but for some reason with your changes the head report
> > got changed as well, I haven't checked the details yet..
> >
> > jirka
>
> The kill returns immediately with no parameter error. Could you try an
> application which can run for a while?
>
> For example:
> perf record -j any,save_type top
sure, but it does not change the fact that the report output is broken,
we need to fix it even for the 'kill' record case
jirka
next prev parent reply other threads:[~2017-04-12 15:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 22:21 [PATCH v4 0/5] perf report: Show branch type Jin Yao
2017-04-11 22:21 ` [PATCH v4 1/5] perf/core: Define the common branch type classification Jin Yao
2017-04-11 22:21 ` [PATCH v4 2/5] perf/x86/intel: Record branch type Jin Yao
2017-04-11 22:21 ` [PATCH v4 3/5] perf record: Create a new option save_type in --branch-filter Jin Yao
2017-04-11 22:21 ` [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode Jin Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:53 ` Jin, Yao
2017-04-19 4:11 ` Jin, Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:41 ` Jin, Yao
2017-04-11 22:21 ` [PATCH v4 5/5] perf report: Show branch type in callchain entry Jin Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:33 ` Jin, Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:32 ` Jin, Yao
2017-04-12 10:58 ` [PATCH v4 0/5] perf report: Show branch type Jiri Olsa
2017-04-12 12:25 ` Jin, Yao
2017-04-12 14:26 ` Jiri Olsa
2017-04-12 15:42 ` Jin, Yao
2017-04-12 15:46 ` Jiri Olsa [this message]
2017-04-13 2:00 ` Jin, Yao
2017-04-13 3:25 ` Jin, Yao
2017-04-13 8:26 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412154659.GA30277@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).