From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3w37Zw4kQxzDq7j for ; Thu, 13 Apr 2017 01:47:04 +1000 (AEST) Date: Wed, 12 Apr 2017 17:46:59 +0200 From: Jiri Olsa To: "Jin, Yao" Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 0/5] perf report: Show branch type Message-ID: <20170412154659.GA30277@krava> References: <1491949266-6835-1-git-send-email-yao.jin@linux.intel.com> <20170412105839.GC14409@krava> <20170412142647.GA27451@krava> <9bbb8cc8-30d4-49b4-771b-fb529024aa98@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <9bbb8cc8-30d4-49b4-771b-fb529024aa98@linux.intel.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Apr 12, 2017 at 11:42:44PM +0800, Jin, Yao wrote: > > > On 4/12/2017 10:26 PM, Jiri Olsa wrote: > > On Wed, Apr 12, 2017 at 08:25:34PM +0800, Jin, Yao wrote: > > > > SNIP > > > > > > # Overhead Command Source Shared Object Source Symbol Target Symbol Basic Block Cycles > > > > # ........ ....... .................... ....................................... ....................................... .................. > > > > # > > > > 8.30% perf > > > > Um [kernel.vmlinux] [k] __intel_pmu_enable_all.constprop.17 [k] native_write_msr - > > > > 7.91% perf > > > > Um [kernel.vmlinux] [k] intel_pmu_lbr_enable_all [k] __intel_pmu_enable_all.constprop.17 - > > > > 7.91% perf > > > > Um [kernel.vmlinux] [k] native_write_msr [k] intel_pmu_lbr_enable_all - > > > > 6.32% kill libc-2.24.so [.] _dl_addr [.] _dl_addr - > > > > 5.93% perf > > > > Um [kernel.vmlinux] [k] perf_iterate_ctx [k] perf_iterate_ctx - > > > > 2.77% kill libc-2.24.so [.] malloc [.] malloc - > > > > 1.98% kill libc-2.24.so [.] _int_malloc [.] _int_malloc - > > > > 1.58% kill [kernel.vmlinux] [k] __rb_insert_augmented [k] __rb_insert_augmented - > > > > 1.58% perf > > > > Um [kernel.vmlinux] [k] perf_event_exec [k] perf_event_exec - > > > > 1.19% kill [kernel.vmlinux] [k] anon_vma_interval_tree_insert [k] anon_vma_interval_tree_insert - > > > > 1.19% kill [kernel.vmlinux] [k] free_pgd_range [k] free_pgd_range - > > > > 1.19% kill [kernel.vmlinux] [k] n_tty_write [k] n_tty_write - > > > > 1.19% perf > > > > Um [kernel.vmlinux] [k] native_sched_clock [k] sched_clock - > > > > ... > > > > SNIP > > > > > > > > > > > > jirka > > > Hi, > > > > > > Thanks so much for trying this patch. > > > > > > The branch statistics is printed at the end of perf report --stdio. > > yep, but for some reason with your changes the head report > > got changed as well, I haven't checked the details yet.. > > > > jirka > > The kill returns immediately with no parameter error. Could you try an > application which can run for a while? > > For example: > perf record -j any,save_type top sure, but it does not change the fact that the report output is broken, we need to fix it even for the 'kill' record case jirka