From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3w7gzm44kczDqC2 for ; Thu, 20 Apr 2017 11:20:51 +1000 (AEST) Date: Thu, 20 Apr 2017 04:20:31 +0300 From: Dan Carpenter To: benh@kernel.crashing.org Cc: linuxppc-dev@lists.ozlabs.org Subject: [bug report] powerpc/xive: Native exploitation of the XIVE interrupt controller Message-ID: <20170420012031.k4vx75eqrm2aborg@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello Benjamin Herrenschmidt, The patch 243e25112d06: "powerpc/xive: Native exploitation of the XIVE interrupt controller" from Apr 5, 2017, leads to the following static checker warning: arch/powerpc/sysdev/xive/native.c:184 __xive_native_disable_queue() info: ignoring unreachable code. arch/powerpc/sysdev/xive/native.c 176 static void __xive_native_disable_queue(u32 vp_id, struct xive_q *q, u8 prio) 177 { 178 s64 rc; 179 180 /* Disable the queue in HW */ 181 for (;;) { 182 rc = opal_xive_set_queue_info(vp_id, prio, 0, 0, 0); 183 break; This should be "if (!rc) break;" 184 msleep(1); 185 } 186 if (rc) But we need some kind of timeout to ever print this error message. 187 pr_err("Error %lld disabling queue for prio %d\n", rc, prio); 188 } regards, dan carpenter