linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org,
	kvm@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH v3] KVM: PPC: Book3S HV: Native usage of the XIVE interrupt controller
Date: Wed, 26 Apr 2017 22:13:30 +1000	[thread overview]
Message-ID: <20170426121330.GA12057@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <1493172450-19636-1-git-send-email-mpe@ellerman.id.au>

On Wed, Apr 26, 2017 at 12:07:30PM +1000, Michael Ellerman wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> This patch makes KVM capable of using the XIVE interrupt controller
> to provide the standard PAPR "XICS" style hypercalls. It is necessary
> for proper operations when the host uses XIVE natively.
> 
> This has been lightly tested on an actual system, including PCI
> pass-through with a TG3 device.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> [mpe: Cleanup pr_xxx(), unsplit pr_xxx() strings, etc., fix build
>  failures by adding KVM_XIVE which depends on KVM_XICS and XIVE, and
>  adding empty stubs for the kvm_xive_xxx() routines, fixup subject]
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

The Kconfig stuff for KVM_XIVE is wrong, you need:

diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index 6498424..c56939e 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -200,7 +200,7 @@ config KVM_XICS
 config KVM_XIVE
 	bool
 	default y
-	depends on KVM_XICS && XIVE_NATIVE
+	depends on KVM_XICS && PPC_XIVE_NATIVE
 
 source drivers/vhost/Kconfig
 
on top of what you posted.

Paul.

  reply	other threads:[~2017-04-26 12:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  2:07 [PATCH v3] KVM: PPC: Book3S HV: Native usage of the XIVE interrupt controller Michael Ellerman
2017-04-26 12:13 ` Paul Mackerras [this message]
2017-04-27 10:12   ` Paul Mackerras
2017-04-27 12:22     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426121330.GA12057@fergus.ozlabs.ibm.com \
    --to=paulus@ozlabs.org \
    --cc=benh@kernel.crashing.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).