From: David Miller <davem@davemloft.net>
To: swood@redhat.com
Cc: Yuval.Mintz@cavium.com, ariel.elior@cavium.com,
everest-linux-l2@cavium.com, netdev@vger.kernel.org,
edumazet@google.com, mschmidt@redhat.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net] bnx2x: Align RX buffers
Date: Sun, 30 Apr 2017 22:50:56 -0400 (EDT) [thread overview]
Message-ID: <20170430.225056.522551868142970014.davem@davemloft.net> (raw)
In-Reply-To: <20170429001741.14563-1-swood@redhat.com>
From: Scott Wood <swood@redhat.com>
Date: Fri, 28 Apr 2017 19:17:41 -0500
> The bnx2x driver is not providing proper alignment on the receive buffers it
> passes to build_skb(), causing skb_shared_info to be misaligned.
> skb_shared_info contains an atomic, and while PPC normally supports
> unaligned accesses, it does not support unaligned atomics.
>
> Aligning the size of rx buffers will ensure that page_frag_alloc() returns
> aligned addresses.
>
> This can be reproduced on PPC by setting the network MTU to 1450 (or other
> non-multiple-of-4) and then generating sufficient inbound network traffic
> (one or two large "wget"s usually does it), producing the following oops:
...
> Fixes: d46d132cc021 ("bnx2x: use netdev_alloc_frag()")
> Signed-off-by: Scott Wood <swood@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2017-05-01 2:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 0:17 [PATCH net] bnx2x: Align RX buffers Scott Wood
2017-05-01 2:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170430.225056.522551868142970014.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yuval.Mintz@cavium.com \
--cc=ariel.elior@cavium.com \
--cc=edumazet@google.com \
--cc=everest-linux-l2@cavium.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=swood@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).