linux-next: build warnings

linux-next: build warnings

[Stephen Rothwell]

Hi all,

The linux-next build (powerpc allyesconfig) produced these warnings
(and have for a while):

arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_enter':
arch/powerpc/kvm/book3s_pr_papr.c:53:2: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
  copy_from_user(pteg, (void __user *)pteg_addr, sizeof(pteg));
  ^
arch/powerpc/kvm/book3s_pr_papr.c:74:2: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result [-Wunused-result]
  copy_to_user((void __user *)pteg_addr, hpte, HPTE_SIZE);
  ^
arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_remove':
arch/powerpc/kvm/book3s_pr_papr.c:96:2: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
  copy_from_user(pte, (void __user *)pteg, sizeof(pte));
  ^
arch/powerpc/kvm/book3s_pr_papr.c:106:2: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result [-Wunused-result]
  copy_to_user((void __user *)pteg, &v, sizeof(v));
  ^
arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_protect':
arch/powerpc/kvm/book3s_pr_papr.c:214:2: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
  copy_from_user(pte, (void __user *)pteg, sizeof(pte));
  ^
arch/powerpc/kvm/book3s_pr_papr.c:237:2: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result [-Wunused-result]
  copy_to_user((void __user *)pteg, pte, sizeof(pte));
  ^
arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_bulk_remove':
arch/powerpc/kvm/book3s_pr_papr.c:174:3: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
   copy_from_user(pte, (void __user *)pteg, sizeof(pte));
   ^
arch/powerpc/kvm/book3s_pr_papr.c:187:4: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result [-Wunused-result]
    copy_to_user((void __user *)pteg, &v, sizeof(v));
    ^

These calls have been there since about v3.1-rc8.  I assume the
copy_to/from_user() work has pointed them out.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings

[Michael Ellerman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> The linux-next build (powerpc allyesconfig) produced these warnings
> (and have for a while):
>
> arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_enter':
> arch/powerpc/kvm/book3s_pr_papr.c:53:2: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
>   copy_from_user(pteg, (void __user *)pteg_addr, sizeof(pteg));
>   ^

Thanks, I had seen them, but they're KVM so I'll leave them to Paul to
fix up.

Though we are supposed to be building with -Werror, so those should be
breaking the build. I assume you have turned Werror off?

cheers

Re: linux-next: build warnings

[Stephen Rothwell]

Hi Michael,

On Tue, 02 May 2017 19:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Though we are supposed to be building with -Werror, so those should be
> breaking the build. I assume you have turned Werror off?

I assume that allyesconfig turns on CONFIG_PPC_DISABLE_WERROR ...
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings

[Stephen Rothwell]

Hi Michael,

On Tue, 2 May 2017 21:17:01 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 02 May 2017 19:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > Though we are supposed to be building with -Werror, so those should be
> > breaking the build. I assume you have turned Werror off?  
> 
> I assume that allyesconfig turns on CONFIG_PPC_DISABLE_WERROR ...

Also, how many configs (if any) turn on CONFIG_KVM_BOOK3S_64_PR?

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings

[Michael Ellerman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:
> On Tue, 02 May 2017 19:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Though we are supposed to be building with -Werror, so those should be
>> breaking the build. I assume you have turned Werror off?
>
> I assume that allyesconfig turns on CONFIG_PPC_DISABLE_WERROR ...

Yep. Sorry you did mention it was allyesconfig in your original mail, zzzz!

cheers