From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wMyCW0cdSzDqKm for ; Wed, 10 May 2017 10:43:35 +1000 (AEST) Received: by mail-io0-x244.google.com with SMTP id f102so713412ioi.3 for ; Tue, 09 May 2017 17:43:34 -0700 (PDT) Date: Tue, 9 May 2017 17:43:27 -0700 From: Dmitry Torokhov To: Michal Suchanek Cc: Benjamin Herrenschmidt , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] macintosh: move mac_hid driver to input/mouse. Message-ID: <20170510004327.GA32584@dtor-ws> References: <20170509191418.10144-1-msuchanek@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170509191418.10144-1-msuchanek@suse.de> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Michal, On Tue, May 09, 2017 at 09:14:18PM +0200, Michal Suchanek wrote: > There is nothing mac-specific about this driver. Non-mac hardware with > suboptimal built-in pointer devices exists. > > This makes it possible to use this emulation not only on x86 and ppc > notebooks but also on arm and mips. I'd rather we did not promote from drivers/macintosh to other platforms, but rather removed it. The same functionality can be done from userspace. What hardware do you believe would benefit from this and why? Thanks. > > Signed-off-by: Michal Suchanek > --- > drivers/input/mouse/Kconfig | 20 ++++++++++++++++++++ > drivers/input/mouse/Makefile | 1 + > drivers/{macintosh => input/mouse}/mac_hid.c | 0 > drivers/macintosh/Kconfig | 17 ----------------- > drivers/macintosh/Makefile | 1 - > 5 files changed, 21 insertions(+), 18 deletions(-) > rename drivers/{macintosh => input/mouse}/mac_hid.c (100%) > > diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig > index 89ebb8f39fee..5533fd3a113f 100644 > --- a/drivers/input/mouse/Kconfig > +++ b/drivers/input/mouse/Kconfig > @@ -12,6 +12,26 @@ menuconfig INPUT_MOUSE > > if INPUT_MOUSE > > +config MAC_EMUMOUSEBTN > + tristate "Support for mouse button 2+3 emulation" > + depends on SYSCTL && INPUT > + help > + This provides generic support for emulating the 2nd and 3rd mouse > + button with keypresses. If you say Y here, the emulation is still > + disabled by default. The emulation is controlled by these sysctl > + entries: > + /proc/sys/dev/mac_hid/mouse_button_emulation > + /proc/sys/dev/mac_hid/mouse_button2_keycode > + /proc/sys/dev/mac_hid/mouse_button3_keycode > + > + If you have an Apple machine with a 1-button mouse, say Y here. > + > + This emulation can be useful on notebooks with suboptimal touchpad > + hardware as well. > + > + To compile this driver as a module, choose M here: the > + module will be called mac_hid. > + > config MOUSE_PS2 > tristate "PS/2 mouse" > default y > diff --git a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile > index 56bf0ad877c6..dfaad1dd8857 100644 > --- a/drivers/input/mouse/Makefile > +++ b/drivers/input/mouse/Makefile > @@ -4,6 +4,7 @@ > > # Each configuration option enables a list of files. > > +obj-$(CONFIG_MAC_EMUMOUSEBTN) += mac_hid.o > obj-$(CONFIG_MOUSE_AMIGA) += amimouse.o > obj-$(CONFIG_MOUSE_APPLETOUCH) += appletouch.o > obj-$(CONFIG_MOUSE_ATARI) += atarimouse.o > diff --git a/drivers/macintosh/mac_hid.c b/drivers/input/mouse/mac_hid.c > similarity index 100% > rename from drivers/macintosh/mac_hid.c > rename to drivers/input/mouse/mac_hid.c > diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig > index 97a420c11eed..011df09c5167 100644 > --- a/drivers/macintosh/Kconfig > +++ b/drivers/macintosh/Kconfig > @@ -159,23 +159,6 @@ config INPUT_ADBHID > > If unsure, say Y. > > -config MAC_EMUMOUSEBTN > - tristate "Support for mouse button 2+3 emulation" > - depends on SYSCTL && INPUT > - help > - This provides generic support for emulating the 2nd and 3rd mouse > - button with keypresses. If you say Y here, the emulation is still > - disabled by default. The emulation is controlled by these sysctl > - entries: > - /proc/sys/dev/mac_hid/mouse_button_emulation > - /proc/sys/dev/mac_hid/mouse_button2_keycode > - /proc/sys/dev/mac_hid/mouse_button3_keycode > - > - If you have an Apple machine with a 1-button mouse, say Y here. > - > - To compile this driver as a module, choose M here: the > - module will be called mac_hid. > - > config THERM_WINDTUNNEL > tristate "Support for thermal management on Windtunnel G4s" > depends on I2C && I2C_POWERMAC && PPC_PMAC && !PPC_PMAC64 > diff --git a/drivers/macintosh/Makefile b/drivers/macintosh/Makefile > index 516eb65bcacc..ab8b1e74d160 100644 > --- a/drivers/macintosh/Makefile > +++ b/drivers/macintosh/Makefile > @@ -7,7 +7,6 @@ > obj-$(CONFIG_PPC_PMAC) += macio_asic.o macio_sysfs.o > > obj-$(CONFIG_PMAC_MEDIABAY) += mediabay.o > -obj-$(CONFIG_MAC_EMUMOUSEBTN) += mac_hid.o > obj-$(CONFIG_INPUT_ADBHID) += adbhid.o > obj-$(CONFIG_ANSLCD) += ans-lcd.o > > -- > 2.10.2 > -- Dmitry