* [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()
@ 2017-05-18 15:24 Wei Yongjun
2017-05-18 17:29 ` Nathan Fontenot
2017-05-18 19:18 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2017-05-18 15:24 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Thomas Falcon, John Allen, Nathan Fontenot
Cc: Wei Yongjun, linuxppc-dev, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Add the missing unlock before return from function __ibmvnic_reset()
in the error handling case.
Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 4f2d329..27f7933 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1313,6 +1313,7 @@ static void __ibmvnic_reset(struct work_struct *work)
if (rc) {
free_all_rwi(adapter);
+ mutex_unlock(&adapter->reset_lock);
return;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()
2017-05-18 15:24 [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset() Wei Yongjun
@ 2017-05-18 17:29 ` Nathan Fontenot
2017-05-18 19:18 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Fontenot @ 2017-05-18 17:29 UTC (permalink / raw)
To: Wei Yongjun, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Thomas Falcon, John Allen
Cc: Wei Yongjun, linuxppc-dev, netdev
On 05/18/2017 10:24 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Add the missing unlock before return from function __ibmvnic_reset()
> in the error handling case.
>
> Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> ---
> drivers/net/ethernet/ibm/ibmvnic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 4f2d329..27f7933 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -1313,6 +1313,7 @@ static void __ibmvnic_reset(struct work_struct *work)
>
> if (rc) {
> free_all_rwi(adapter);
> + mutex_unlock(&adapter->reset_lock);
> return;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()
2017-05-18 15:24 [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset() Wei Yongjun
2017-05-18 17:29 ` Nathan Fontenot
@ 2017-05-18 19:18 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-05-18 19:18 UTC (permalink / raw)
To: weiyj.lk
Cc: benh, paulus, mpe, tlfalcon, jallen, nfont, weiyongjun1,
linuxppc-dev, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Thu, 18 May 2017 15:24:52 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Add the missing unlock before return from function __ibmvnic_reset()
> in the error handling case.
>
> Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-18 19:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-18 15:24 [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset() Wei Yongjun
2017-05-18 17:29 ` Nathan Fontenot
2017-05-18 19:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).