* [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
@ 2017-05-29 13:26 Murilo Opsfelder Araujo
2017-05-29 19:07 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Murilo Opsfelder Araujo @ 2017-05-29 13:26 UTC (permalink / raw)
To: linux-kernel
Cc: linux-watchdog, Guenter Roeck, Wim Van Sebroeck, linuxppc-dev,
Michael Ellerman, Murilo Opsfelder Araujo
drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
setting CONFIG_PPC_RTAS throws the following errors:
ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
CONFIG_PPC_RTAS was not set. Logs are here:
http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just
CONFIG_PPC_RTAS, removing COMPILE_TEST entirely.
Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
---
drivers/watchdog/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 8b9049d..e6e31a1 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1688,7 +1688,7 @@ config MEN_A21_WDT
config WATCHDOG_RTAS
tristate "RTAS watchdog"
- depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
+ depends on PPC_RTAS
help
This driver adds watchdog support for the RTAS watchdog.
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
2017-05-29 13:26 [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo
@ 2017-05-29 19:07 ` Guenter Roeck
2017-05-30 10:55 ` Michael Ellerman
2017-06-19 12:25 ` [v2] " Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2017-05-29 19:07 UTC (permalink / raw)
To: Murilo Opsfelder Araujo, linux-kernel
Cc: linux-watchdog, Wim Van Sebroeck, linuxppc-dev, Michael Ellerman
On 05/29/2017 06:26 AM, Murilo Opsfelder Araujo wrote:
> drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
> which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
> setting CONFIG_PPC_RTAS throws the following errors:
>
> ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
>
> This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
> CONFIG_PPC_RTAS was not set. Logs are here:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
>
> This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just
> CONFIG_PPC_RTAS, removing COMPILE_TEST entirely.
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 8b9049d..e6e31a1 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1688,7 +1688,7 @@ config MEN_A21_WDT
>
> config WATCHDOG_RTAS
> tristate "RTAS watchdog"
> - depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
> + depends on PPC_RTAS
> help
> This driver adds watchdog support for the RTAS watchdog.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
2017-05-29 13:26 [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo
2017-05-29 19:07 ` Guenter Roeck
@ 2017-05-30 10:55 ` Michael Ellerman
2017-06-19 12:25 ` [v2] " Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2017-05-30 10:55 UTC (permalink / raw)
To: Murilo Opsfelder Araujo, linux-kernel
Cc: linux-watchdog, Guenter Roeck, Wim Van Sebroeck, linuxppc-dev,
Murilo Opsfelder Araujo
Murilo Opsfelder Araujo <mopsfelder@gmail.com> writes:
> drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
> which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
> setting CONFIG_PPC_RTAS throws the following errors:
>
> ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
>
> This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
> CONFIG_PPC_RTAS was not set. Logs are here:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
>
> This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just
> CONFIG_PPC_RTAS, removing COMPILE_TEST entirely.
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
> ---
> drivers/watchdog/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
2017-05-29 13:26 [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo
2017-05-29 19:07 ` Guenter Roeck
2017-05-30 10:55 ` Michael Ellerman
@ 2017-06-19 12:25 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2017-06-19 12:25 UTC (permalink / raw)
To: Murilo Opsfelder Araujo, linux-kernel
Cc: linux-watchdog, Murilo Opsfelder Araujo, Wim Van Sebroeck,
linuxppc-dev, Guenter Roeck
On Mon, 2017-05-29 at 13:26:28 UTC, Murilo Opsfelder Araujo wrote:
> drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
> which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
> setting CONFIG_PPC_RTAS throws the following errors:
>
> ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
>
> This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
> CONFIG_PPC_RTAS was not set. Logs are here:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
>
> This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just
> CONFIG_PPC_RTAS, removing COMPILE_TEST entirely.
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/42bed042556261b56aa92e05f4f388
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-19 12:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-29 13:26 [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo
2017-05-29 19:07 ` Guenter Roeck
2017-05-30 10:55 ` Michael Ellerman
2017-06-19 12:25 ` [v2] " Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).