From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: bp@alien8.de, mchehab@kernel.org, linux-edac@vger.kernel.org,
mpe@ellerman.id.au
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v3 1/3] EDAC: mv64x60: check driver registration success
Date: Tue, 30 May 2017 09:21:40 +1200 [thread overview]
Message-ID: <20170529212142.25572-2-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20170529212142.25572-1-chris.packham@alliedtelesis.co.nz>
Check the return status of platform_driver_register() in
mv64x60_edac_init(). Only output messages and initialise the
edac_op_state if the registration is successful.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Changes in v3:
- catch the retval of platform_register_drivers and return early on failure
(thanks Borislav).
drivers/edac/mv64x60_edac.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c
index 14b7e7b71eaa..172081551a70 100644
--- a/drivers/edac/mv64x60_edac.c
+++ b/drivers/edac/mv64x60_edac.c
@@ -853,7 +853,11 @@ static struct platform_driver * const drivers[] = {
static int __init mv64x60_edac_init(void)
{
- int ret = 0;
+ int ret;
+
+ ret = platform_register_drivers(drivers, ARRAY_SIZE(drivers));
+ if (ret)
+ return ret;
printk(KERN_INFO "Marvell MV64x60 EDAC driver " MV64x60_REVISION "\n");
printk(KERN_INFO "\t(C) 2006-2007 MontaVista Software\n");
@@ -867,7 +871,7 @@ static int __init mv64x60_edac_init(void)
break;
}
- return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
+ return 0;
}
module_init(mv64x60_edac_init);
--
2.13.0
next prev parent reply other threads:[~2017-05-29 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 21:21 [PATCH v3 0/3] EDAC: mv64x60: updates Chris Packham
2017-05-29 21:21 ` Chris Packham [this message]
2017-06-07 5:29 ` [PATCH v3 1/3] EDAC: mv64x60: check driver registration success Chris Packham
2017-06-07 9:54 ` Borislav Petkov
2017-05-29 21:21 ` [PATCH v3 2/3] EDAC: mv64x60: Fix pdata->name Chris Packham
2017-05-29 21:21 ` [PATCH v3 3/3] EDAC: mv64x60: replace in_le32/out_le32 with readl/writel Chris Packham
2017-05-30 7:57 ` [PATCH v3 0/3] EDAC: mv64x60: updates Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170529212142.25572-2-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mchehab@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).