linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, mikey@neuling.org, paulus@samba.org,
	npiggin@gmail.com
Subject: Re: [PATCH] powerpc/64: Reclaim CPU_FTR_SUBCORE
Date: Tue, 30 May 2017 12:48:00 +1000	[thread overview]
Message-ID: <20170530124800.11dbc61b@firefly.ozlabs.ibm.com> (raw)
In-Reply-To: <1496022790-2017-1-git-send-email-mpe@ellerman.id.au>

On Mon, 29 May 2017 11:53:10 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:

> We are running low on CPU feature bits, so we only want to use them when
> it's really necessary.
> 
> CPU_FTR_SUBCORE is only used in one place, and only in C, so we don't
> need it in order to make asm patching work. It can only be set on
> "Power8" CPUs, which in practice means POWER8, POWER8E and POWER8NVL.
> There are no plans to implement it on future CPUs, but if there ever
> were we could retrofit it then.
> 
> Although KVM uses subcores, it never looks at the CPU feature, it either
> looks at the ISA level or the threads_per_subcore value.
> 
> So drop the CPU feature and do a PVR check instead. Drop the device tree
> "subcore" feature as we no longer support doing anything with it, and we
> will drop it from skiboot too.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---

Acked-by: Balbir Singh <bsingharora@gmail.com>

I looked at CPU_FTR_DBELL and its used for initialization and in
arch_show_interrupts(), no assembly

it may be another candidate for reclaim

Balbir Singh.

  reply	other threads:[~2017-05-30  2:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29  1:53 [PATCH] powerpc/64: Reclaim CPU_FTR_SUBCORE Michael Ellerman
2017-05-30  2:48 ` Balbir Singh [this message]
2017-05-30 10:48   ` Michael Ellerman
2017-06-01 13:31 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530124800.11dbc61b@firefly.ozlabs.ibm.com \
    --to=bsingharora@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).