Re: [PATCH v1 1/3] powerpc, 8xx: remove support for 8xx

Re: [PATCH v1 1/3] powerpc, 8xx: remove support for 8xx

[Christophe LEROY]

Le 13/06/2017 à 09:37, Heiko Schocher a écrit :
> Hello Christophe,
> 
> Am 13.06.2017 um 07:40 schrieb Christophe LEROY:
>>
>>
>> Le 13/06/2017 à 07:26, Christophe LEROY a écrit :
>>> There was for long time no activity in the 8xx area.
>>> We need to go further and convert to Kconfig, but it
>>> turned out, nobody is interested anymore in 8xx,
>>> so remove it (with a heavy heart, knowing that I remove
>>> here the root of U-Boot).
>>>
>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>
>>
>> Please don't do that.
> 
> Tom already applied the patch to mainline ...

Can be reverted ?

> 
>> As you can see in Linux kernel activity, there have been a lot 
>> activity related to the 8xx,
>> including but not limited to:
>> 1/ HW Crypto for the 885 (Talitos SEC1)
>> 2/ TX NAPI in the 8xx Ethernet driver
>> 3/ Scatter/Gather support in the 8xx Ethernet driver
>> 4/ Hugepages
>> 5/ Perf events
>> 6/ hw breakpoints
>> 7/ Linear memory mapping via Large TLBs
> 
> Thats linux ... not u-boot!

Sure, but it shows there is still interest to that processor. The 885 is 
a good recent 8xx.
u-boot is not really something we focus on. We update it once a year, as 
far as it can start our Linux box we are happy.

> 
>> The followings links give an overview of the activity:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/crypto/talitos.c 
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c 
>>
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/arch/powerpc/kernel/head_8xx.S 
>>
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/arch/powerpc/mm/8xx_mmu.c 
>>
>>
>> We have thousands of boards with mpc885 running and requiring support 
>> for at least the next 10 years.
> 
> Ok, nice to hear!
> 
>> How can the 8xx survive without U-boot support ?
> 
> Tom asked (I think a lot of times) regarding converting mpc8xx to
> Kconfig / DM and nobody did the necessary steps. We also asked
> our customers if they can do the necessary changes, none was interested.

I did't know. Indeed I was not following uboot activity until someone 
who knows the level of interest we have in 8xx alerted me yesterday.
It would have been nice if you had notified linuxppc-dev list.

> 
> So, if you need mpc8xx support in U-Boot, simply add it again with
> Kconfig and DM support included!

Ok, I'll try and come with a patch to convert 8xx in the coming weeks. 
In the mean time please revert the deletion in order to avoid nightmare 
conflicts when the converting patch comes.

Thanks
Christophe

Re: [PATCH v1 1/3] powerpc, 8xx: remove support for 8xx

[Heiko Schocher]

Hello Christophe,

Am 14.06.2017 um 09:40 schrieb Christophe LEROY:
>
>
> Le 13/06/2017 à 09:37, Heiko Schocher a écrit :
>> Hello Christophe,
>>
>> Am 13.06.2017 um 07:40 schrieb Christophe LEROY:
>>>
>>>
>>> Le 13/06/2017 à 07:26, Christophe LEROY a écrit :
>>>> There was for long time no activity in the 8xx area.
>>>> We need to go further and convert to Kconfig, but it
>>>> turned out, nobody is interested anymore in 8xx,
>>>> so remove it (with a heavy heart, knowing that I remove
>>>> here the root of U-Boot).
>>>>
>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>>
>>>
>>> Please don't do that.
>>
>> Tom already applied the patch to mainline ...
>
> Can be reverted ?
>
>>
>>> As you can see in Linux kernel activity, there have been a lot activity related to the 8xx,
>>> including but not limited to:
>>> 1/ HW Crypto for the 885 (Talitos SEC1)
>>> 2/ TX NAPI in the 8xx Ethernet driver
>>> 3/ Scatter/Gather support in the 8xx Ethernet driver
>>> 4/ Hugepages
>>> 5/ Perf events
>>> 6/ hw breakpoints
>>> 7/ Linear memory mapping via Large TLBs
>>
>> Thats linux ... not u-boot!
>
> Sure, but it shows there is still interest to that processor. The 885 is a good recent 8xx.
> u-boot is not really something we focus on. We update it once a year, as far as it can start our
> Linux box we are happy.

Hmm...

>>> The followings links give an overview of the activity:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/crypto/talitos.c
>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
>>>
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/arch/powerpc/kernel/head_8xx.S
>>>
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/arch/powerpc/mm/8xx_mmu.c
>>>
>>>
>>> We have thousands of boards with mpc885 running and requiring support for at least the next 10
>>> years.
>>
>> Ok, nice to hear!
>>
>>> How can the 8xx survive without U-boot support ?
>>
>> Tom asked (I think a lot of times) regarding converting mpc8xx to
>> Kconfig / DM and nobody did the necessary steps. We also asked
>> our customers if they can do the necessary changes, none was interested.
>
> I did't know. Indeed I was not following uboot activity until someone who knows the level of
> interest we have in 8xx alerted me yesterday.
> It would have been nice if you had notified linuxppc-dev list.
>
>>
>> So, if you need mpc8xx support in U-Boot, simply add it again with
>> Kconfig and DM support included!
>
> Ok, I'll try and come with a patch to convert 8xx in the coming weeks. In the mean time please
> revert the deletion in order to avoid nightmare conflicts when the converting patch comes.

I vote for making a patch which adds new mpc8xx support, as we had a lot
of crap in the code, but thats Tom decision!

bye,
Heiko
-- 
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [PATCH v1 1/3] powerpc, 8xx: remove support for 8xx

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 3890 bytes --]

On Wed, Jun 14, 2017 at 09:40:18AM +0200, Christophe LEROY wrote:
> 
> 
> Le 13/06/2017 à 09:37, Heiko Schocher a écrit :
> >Hello Christophe,
> >
> >Am 13.06.2017 um 07:40 schrieb Christophe LEROY:
> >>
> >>
> >>Le 13/06/2017 à 07:26, Christophe LEROY a écrit :
> >>>There was for long time no activity in the 8xx area.
> >>>We need to go further and convert to Kconfig, but it
> >>>turned out, nobody is interested anymore in 8xx,
> >>>so remove it (with a heavy heart, knowing that I remove
> >>>here the root of U-Boot).
> >>>
> >>>Signed-off-by: Heiko Schocher <hs@denx.de>
> >>>
> >>
> >>Please don't do that.
> >
> >Tom already applied the patch to mainline ...
> 
> Can be reverted ?

It's not a trivial revert, but it wouldn't take took long to resolve the
conflicts, for someone that's interested in the architecture.

> >>As you can see in Linux kernel activity, there have been a lot
> >>activity related to the 8xx,
> >>including but not limited to:
> >>1/ HW Crypto for the 885 (Talitos SEC1)
> >>2/ TX NAPI in the 8xx Ethernet driver
> >>3/ Scatter/Gather support in the 8xx Ethernet driver
> >>4/ Hugepages
> >>5/ Perf events
> >>6/ hw breakpoints
> >>7/ Linear memory mapping via Large TLBs
> >
> >Thats linux ... not u-boot!
> 
> Sure, but it shows there is still interest to that processor. The
> 885 is a good recent 8xx.
> u-boot is not really something we focus on. We update it once a
> year, as far as it can start our Linux box we are happy.

I suppose this highlights the risks of not upstreaming your code.  If
someone had been submitting a new board in the last few years, they
would (likely, yes, we've made a few mistakes in missing maintainers at
times) have been CC'd on one of the "Does anyone care about this still?"
messages that've been both in public and in private.

> >>The followings links give an overview of the activity:
> >>
> >>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/crypto/talitos.c
> >>
> >>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> >>
> >>
> >>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/arch/powerpc/kernel/head_8xx.S
> >>
> >>
> >>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/arch/powerpc/mm/8xx_mmu.c
> >>
> >>
> >>We have thousands of boards with mpc885 running and requiring
> >>support for at least the next 10 years.
> >
> >Ok, nice to hear!
> >
> >>How can the 8xx survive without U-boot support ?
> >
> >Tom asked (I think a lot of times) regarding converting mpc8xx to
> >Kconfig / DM and nobody did the necessary steps. We also asked
> >our customers if they can do the necessary changes, none was interested.
> 
> I did't know. Indeed I was not following uboot activity until
> someone who knows the level of interest we have in 8xx alerted me
> yesterday.
> It would have been nice if you had notified linuxppc-dev list.
> 
> >
> >So, if you need mpc8xx support in U-Boot, simply add it again with
> >Kconfig and DM support included!
> 
> Ok, I'll try and come with a patch to convert 8xx in the coming
> weeks. In the mean time please revert the deletion in order to avoid
> nightmare conflicts when the converting patch comes.

Well, how about this.  Now that you know there's a problem, and a need
for a maintainer, can you please submit a patch, in the next say 2
weeks, that brings back the core of mpc8xx and lists you (or someone
else from your company) as the maintainer for mpc8xx, and we'll aim for
v2017.09 as having (a) one of your platforms, or relevant reference
platform in mainline.  I don't want "just a revert" as there's many
boards that no, we don't want anymore as no one is maintaining them.
Thanks!

-- 
Tom

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]