* [PATCH 0/2] fix loadable module for DPAA Ethernet
@ 2017-06-19 15:04 Madalin Bucur
2017-06-19 15:04 ` [PATCH 1/2] fsl/fman: propagate dma_ops Madalin Bucur
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Madalin Bucur @ 2017-06-19 15:04 UTC (permalink / raw)
To: netdev, davem; +Cc: linuxppc-dev, linux-kernel, Madalin Bucur
The DPAA Ethernet makes use of a symbol that is not exported.
Address the issue by propagating the dma_ops rather than calling
arch_setup_dma_ops().
Madalin Bucur (2):
fsl/fman: propagate dma_ops
dpaa_eth: reuse the dma_ops provided by the FMan MAC device
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
drivers/net/ethernet/freescale/fman/mac.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
--
2.1.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] fsl/fman: propagate dma_ops 2017-06-19 15:04 [PATCH 0/2] fix loadable module for DPAA Ethernet Madalin Bucur @ 2017-06-19 15:04 ` Madalin Bucur 2017-06-26 7:48 ` Geert Uytterhoeven 2017-06-19 15:04 ` [PATCH 2/2] dpaa_eth: reuse the dma_ops provided by the FMan MAC device Madalin Bucur 2017-06-20 17:47 ` [PATCH 0/2] fix loadable module for DPAA Ethernet David Miller 2 siblings, 1 reply; 8+ messages in thread From: Madalin Bucur @ 2017-06-19 15:04 UTC (permalink / raw) To: netdev, davem; +Cc: linuxppc-dev, linux-kernel, Madalin Bucur Make sure dma_ops are set, to be later used by the Ethernet driver. Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/ethernet/freescale/fman/mac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 0b31f85..6e67d22f 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -623,6 +623,8 @@ static struct platform_device *dpaa_eth_add_device(int fman_id, goto no_mem; } + set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); + ret = platform_device_add_data(pdev, &data, sizeof(data)); if (ret) goto err; -- 2.1.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] fsl/fman: propagate dma_ops 2017-06-19 15:04 ` [PATCH 1/2] fsl/fman: propagate dma_ops Madalin Bucur @ 2017-06-26 7:48 ` Geert Uytterhoeven 2017-06-26 14:55 ` Madalin-cristian Bucur 0 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2017-06-26 7:48 UTC (permalink / raw) To: madalin.bucur Cc: netdev@vger.kernel.org, David S. Miller, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Hi Madalin, On Mon, Jun 19, 2017 at 5:04 PM, Madalin Bucur <madalin.bucur@nxp.com> wrot= e: > Make sure dma_ops are set, to be later used by the Ethernet driver. > > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > --- > drivers/net/ethernet/freescale/fman/mac.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethe= rnet/freescale/fman/mac.c > index 0b31f85..6e67d22f 100644 > --- a/drivers/net/ethernet/freescale/fman/mac.c > +++ b/drivers/net/ethernet/freescale/fman/mac.c > @@ -623,6 +623,8 @@ static struct platform_device *dpaa_eth_add_device(in= t fman_id, > goto no_mem; > } > > + set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); > + When compile-testing with f NO_DMA=3Dy: drivers/net/ethernet/freescale/fman/mac.c: In function =E2=80=98dpaa_eth_add_device=E2=80=99: drivers/net/ethernet/freescale/fman/mac.c:626: error: implicit declaration of function =E2=80=98set_dma_ops=E2=80=99 Reverting commit 5567e989198b5a8d fixes this regression in v4.12-rc7. Why is this change needed? There's no single other call to the DMA API in this file? If it's really needed, can't set_dma_ops() be called from the driver that needs it, cfr. your other patch "[PATCH 2/2] dpaa_eth: reuse the dma_ops provided by the FMan MAC device"? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] fsl/fman: propagate dma_ops 2017-06-26 7:48 ` Geert Uytterhoeven @ 2017-06-26 14:55 ` Madalin-cristian Bucur 2017-06-26 16:24 ` Geert Uytterhoeven 0 siblings, 1 reply; 8+ messages in thread From: Madalin-cristian Bucur @ 2017-06-26 14:55 UTC (permalink / raw) To: Geert Uytterhoeven Cc: netdev@vger.kernel.org, David S. Miller, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBnZWVydC51eXR0ZXJob2V2ZW5A Z21haWwuY29tIFttYWlsdG86Z2VlcnQudXl0dGVyaG9ldmVuQGdtYWlsLmNvbV0NCj4gT24gQmVo YWxmIE9mIEdlZXJ0IFV5dHRlcmhvZXZlbg0KPiBTZW50OiBNb25kYXksIEp1bmUgMjYsIDIwMTcg MTA6NDkgQU0NCj4gVG86IE1hZGFsaW4tY3Jpc3RpYW4gQnVjdXIgPG1hZGFsaW4uYnVjdXJAbnhw LmNvbT4NCj4gQ2M6IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmc7IERhdmlkIFMuIE1pbGxlciA8ZGF2 ZW1AZGF2ZW1sb2Z0Lm5ldD47DQo+IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBsaW51 eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8yXSBmc2wv Zm1hbjogcHJvcGFnYXRlIGRtYV9vcHMNCj4gDQo+IEhpIE1hZGFsaW4sDQo+IA0KPiBPbiBNb24s IEp1biAxOSwgMjAxNyBhdCA1OjA0IFBNLCBNYWRhbGluIEJ1Y3VyIDxtYWRhbGluLmJ1Y3VyQG54 cC5jb20+DQo+IHdyb3RlOg0KPiA+IE1ha2Ugc3VyZSBkbWFfb3BzIGFyZSBzZXQsIHRvIGJlIGxh dGVyIHVzZWQgYnkgdGhlIEV0aGVybmV0IGRyaXZlci4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6 IE1hZGFsaW4gQnVjdXIgPG1hZGFsaW4uYnVjdXJAbnhwLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJp dmVycy9uZXQvZXRoZXJuZXQvZnJlZXNjYWxlL2ZtYW4vbWFjLmMgfCAyICsrDQo+ID4gIDEgZmls ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L25ldC9ldGhlcm5ldC9mcmVlc2NhbGUvZm1hbi9tYWMuYw0KPiBiL2RyaXZlcnMvbmV0L2V0aGVy bmV0L2ZyZWVzY2FsZS9mbWFuL21hYy5jDQo+ID4gaW5kZXggMGIzMWY4NS4uNmU2N2QyMmYgMTAw NjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvZnJlZXNjYWxlL2ZtYW4vbWFjLmMN Cj4gPiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9mcmVlc2NhbGUvZm1hbi9tYWMuYw0KPiA+ IEBAIC02MjMsNiArNjIzLDggQEAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UNCj4gKmRw YWFfZXRoX2FkZF9kZXZpY2UoaW50IGZtYW5faWQsDQo+ID4gICAgICAgICAgICAgICAgIGdvdG8g bm9fbWVtOw0KPiA+ICAgICAgICAgfQ0KPiA+DQo+ID4gKyAgICAgICBzZXRfZG1hX29wcygmcGRl di0+ZGV2LCBnZXRfZG1hX29wcyhwcml2LT5kZXYpKTsNCj4gPiArDQo+IA0KPiBXaGVuIGNvbXBp bGUtdGVzdGluZyB3aXRoIGYgTk9fRE1BPXk6DQo+IA0KPiAgICAgZHJpdmVycy9uZXQvZXRoZXJu ZXQvZnJlZXNjYWxlL2ZtYW4vbWFjLmM6IEluIGZ1bmN0aW9uDQo+IOKAmGRwYWFfZXRoX2FkZF9k ZXZpY2XigJk6DQo+ICAgICBkcml2ZXJzL25ldC9ldGhlcm5ldC9mcmVlc2NhbGUvZm1hbi9tYWMu Yzo2MjY6IGVycm9yOiBpbXBsaWNpdA0KPiBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbiDigJhzZXRf ZG1hX29wc+KAmQ0KPiANCj4gUmV2ZXJ0aW5nIGNvbW1pdCA1NTY3ZTk4OTE5OGI1YThkIGZpeGVz IHRoaXMgcmVncmVzc2lvbiBpbiB2NC4xMi1yYzcuDQo+IA0KPiBXaHkgaXMgdGhpcyBjaGFuZ2Ug bmVlZGVkPw0KPiBUaGVyZSdzIG5vIHNpbmdsZSBvdGhlciBjYWxsIHRvIHRoZSBETUEgQVBJIGlu IHRoaXMgZmlsZT8NCg0KV2UncmUgc2V0dGluZyBoZXJlIHRoZSBkbWFfb3BzIHRoYXQgYXJlIGxh dGVyIHVzZWQgaW4gdGhlIG90aGVyIGRyaXZlci9wYXRjaC4NClRoZSBwcm9ibGVtIGlzIHdlIG5v dyBkZXBlbmQgdXBvbiBETUEgYnV0IGRvIG5vdCBleHBsaWNpdGx5IGRlY2xhcmUgaXQ6DQoNCjw8 Q29kZSB0aGF0IGRlcGVuZHMgb24gdGhlIGRtYS1tYXBwaW5nIEFQSSBuZWVkcyB0byBzZXQgJ2Rl cGVuZHMgb24gSEFTX0RNQScNCmluIGl0cyBLY29uZmlnPj4NCg0KSSdsbCBuZWVkIHRvIGFkZCB0 aGlzIHRvIHRoZSBGTWFuIGRyaXZlciBLY29uZmlnLiANCg0KPiBJZiBpdCdzIHJlYWxseSBuZWVk ZWQsIGNhbid0IHNldF9kbWFfb3BzKCkgYmUgY2FsbGVkIGZyb20gdGhlIGRyaXZlciB0aGF0DQo+ IG5lZWRzIGl0LCBjZnIuIHlvdXIgb3RoZXIgcGF0Y2ggIltQQVRDSCAyLzJdIGRwYWFfZXRoOiBy ZXVzZSB0aGUgZG1hX29wcw0KPiBwcm92aWRlZCBieSB0aGUgRk1hbiBNQUMgZGV2aWNlIj8NCj4g DQo+IFRoYW5rcyENCj4gDQo+IEdye29ldGplLGVldGluZ31zLA0KPiANCj4gICAgICAgICAgICAg ICAgICAgICAgICAgR2VlcnQNCj4gDQo+IC0tDQo+IEdlZXJ0IFV5dHRlcmhvZXZlbiAtLSBUaGVy ZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgtDQo+IG02OGsub3Jn DQo+IA0KPiBJbiBwZXJzb25hbCBjb252ZXJzYXRpb25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwg SSBjYWxsIG15c2VsZiBhIGhhY2tlci4NCj4gQnV0DQo+IHdoZW4gSSdtIHRhbGtpbmcgdG8gam91 cm5hbGlzdHMgSSBqdXN0IHNheSAicHJvZ3JhbW1lciIgb3Igc29tZXRoaW5nIGxpa2UNCj4gdGhh dC4NCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51cyBUb3J2YWxkcw0K DQpUaGFua3MsDQpNYWRhbGluDQo= ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] fsl/fman: propagate dma_ops 2017-06-26 14:55 ` Madalin-cristian Bucur @ 2017-06-26 16:24 ` Geert Uytterhoeven 2017-06-27 6:49 ` Madalin-cristian Bucur 0 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2017-06-26 16:24 UTC (permalink / raw) To: Madalin-cristian Bucur Cc: netdev@vger.kernel.org, David S. Miller, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Hi Madalin, On Mon, Jun 26, 2017 at 4:55 PM, Madalin-cristian Bucur <madalin.bucur@nxp.com> wrote: >> -----Original Message----- >> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] >> On Behalf Of Geert Uytterhoeven >> Sent: Monday, June 26, 2017 10:49 AM >> To: Madalin-cristian Bucur <madalin.bucur@nxp.com> >> Cc: netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; >> linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH 1/2] fsl/fman: propagate dma_ops >> > On Mon, Jun 19, 2017 at 5:04 PM, Madalin Bucur <madalin.bucur@nxp.com> >> wrote: >> > Make sure dma_ops are set, to be later used by the Ethernet driver. >> > >> > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> >> > --- >> > drivers/net/ethernet/freescale/fman/mac.c | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/drivers/net/ethernet/freescale/fman/mac.c >> b/drivers/net/ethernet/freescale/fman/mac.c >> > index 0b31f85..6e67d22f 100644 >> > --- a/drivers/net/ethernet/freescale/fman/mac.c >> > +++ b/drivers/net/ethernet/freescale/fman/mac.c >> > @@ -623,6 +623,8 @@ static struct platform_device >> *dpaa_eth_add_device(int fman_id, >> > goto no_mem; >> > } >> > >> > + set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); >> > + >> >> When compile-testing with f NO_DMA=3Dy: >> >> drivers/net/ethernet/freescale/fman/mac.c: In function >> =E2=80=98dpaa_eth_add_device=E2=80=99: >> drivers/net/ethernet/freescale/fman/mac.c:626: error: implicit >> declaration of function =E2=80=98set_dma_ops=E2=80=99 >> >> Reverting commit 5567e989198b5a8d fixes this regression in v4.12-rc7. >> >> Why is this change needed? >> There's no single other call to the DMA API in this file? > > We're setting here the dma_ops that are later used in the other driver/pa= tch. > The problem is we now depend upon DMA but do not explicitly declare it: > > <<Code that depends on the dma-mapping API needs to set 'depends on HAS_D= MA' > in its Kconfig>> Sure. But only if the driver really uses DMA. I can stick a set_dma_ops() call in whatever driver, but that doesn't mean it will suddenly use DMA. Why does the FMan driver suddenly has a dependency on DMA, if it doesn't use DMA? > I'll need to add this to the FMan driver Kconfig. Why does the FMan driver need this? Why can't his call be done in the driver that uses the DMA APIO? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] fsl/fman: propagate dma_ops 2017-06-26 16:24 ` Geert Uytterhoeven @ 2017-06-27 6:49 ` Madalin-cristian Bucur 0 siblings, 0 replies; 8+ messages in thread From: Madalin-cristian Bucur @ 2017-06-27 6:49 UTC (permalink / raw) To: Geert Uytterhoeven Cc: netdev@vger.kernel.org, David S. Miller, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBnZWVydC51eXR0ZXJob2V2ZW5A Z21haWwuY29tIFttYWlsdG86Z2VlcnQudXl0dGVyaG9ldmVuQGdtYWlsLmNvbV0NCj4gT24gQmVo YWxmIE9mIEdlZXJ0IFV5dHRlcmhvZXZlbg0KPiBTZW50OiBNb25kYXksIEp1bmUgMjYsIDIwMTcg NzoyNCBQTQ0KPiBUbzogTWFkYWxpbi1jcmlzdGlhbiBCdWN1ciA8bWFkYWxpbi5idWN1ckBueHAu Y29tPg0KPiBDYzogbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsgRGF2aWQgUy4gTWlsbGVyIDxkYXZl bUBkYXZlbWxvZnQubmV0PjsNCj4gbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4 LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIGZzbC9m bWFuOiBwcm9wYWdhdGUgZG1hX29wcw0KPiANCj4gSGkgTWFkYWxpbiwNCj4gDQo+IE9uIE1vbiwg SnVuIDI2LCAyMDE3IGF0IDQ6NTUgUE0sIE1hZGFsaW4tY3Jpc3RpYW4gQnVjdXINCj4gPG1hZGFs aW4uYnVjdXJAbnhwLmNvbT4gd3JvdGU6DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t DQo+ID4+IEZyb206IGdlZXJ0LnV5dHRlcmhvZXZlbkBnbWFpbC5jb20NCj4gW21haWx0bzpnZWVy dC51eXR0ZXJob2V2ZW5AZ21haWwuY29tXQ0KPiA+PiBPbiBCZWhhbGYgT2YgR2VlcnQgVXl0dGVy aG9ldmVuDQo+ID4+IFNlbnQ6IE1vbmRheSwgSnVuZSAyNiwgMjAxNyAxMDo0OSBBTQ0KPiA+PiBU bzogTWFkYWxpbi1jcmlzdGlhbiBCdWN1ciA8bWFkYWxpbi5idWN1ckBueHAuY29tPg0KPiA+PiBD YzogbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsgRGF2aWQgUy4gTWlsbGVyIDxkYXZlbUBkYXZlbWxv ZnQubmV0PjsNCj4gPj4gbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWtlcm5l bEB2Z2VyLmtlcm5lbC5vcmcNCj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIGZzbC9mbWFu OiBwcm9wYWdhdGUgZG1hX29wcw0KPiA+Pg0KPiA+IE9uIE1vbiwgSnVuIDE5LCAyMDE3IGF0IDU6 MDQgUE0sIE1hZGFsaW4gQnVjdXIgPG1hZGFsaW4uYnVjdXJAbnhwLmNvbT4NCj4gPj4gd3JvdGU6 DQo+ID4+ID4gTWFrZSBzdXJlIGRtYV9vcHMgYXJlIHNldCwgdG8gYmUgbGF0ZXIgdXNlZCBieSB0 aGUgRXRoZXJuZXQgZHJpdmVyLg0KPiA+PiA+DQo+ID4+ID4gU2lnbmVkLW9mZi1ieTogTWFkYWxp biBCdWN1ciA8bWFkYWxpbi5idWN1ckBueHAuY29tPg0KPiA+PiA+IC0tLQ0KPiA+PiA+ICBkcml2 ZXJzL25ldC9ldGhlcm5ldC9mcmVlc2NhbGUvZm1hbi9tYWMuYyB8IDIgKysNCj4gPj4gPiAgMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQ0KPiA+PiA+DQo+ID4+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvbmV0L2V0aGVybmV0L2ZyZWVzY2FsZS9mbWFuL21hYy5jDQo+ID4+IGIvZHJpdmVy cy9uZXQvZXRoZXJuZXQvZnJlZXNjYWxlL2ZtYW4vbWFjLmMNCj4gPj4gPiBpbmRleCAwYjMxZjg1 Li42ZTY3ZDIyZiAxMDA2NDQNCj4gPj4gPiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9mcmVl c2NhbGUvZm1hbi9tYWMuYw0KPiA+PiA+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2ZyZWVz Y2FsZS9mbWFuL21hYy5jDQo+ID4+ID4gQEAgLTYyMyw2ICs2MjMsOCBAQCBzdGF0aWMgc3RydWN0 IHBsYXRmb3JtX2RldmljZQ0KPiA+PiAqZHBhYV9ldGhfYWRkX2RldmljZShpbnQgZm1hbl9pZCwN Cj4gPj4gPiAgICAgICAgICAgICAgICAgZ290byBub19tZW07DQo+ID4+ID4gICAgICAgICB9DQo+ ID4+ID4NCj4gPj4gPiArICAgICAgIHNldF9kbWFfb3BzKCZwZGV2LT5kZXYsIGdldF9kbWFfb3Bz KHByaXYtPmRldikpOw0KPiA+PiA+ICsNCj4gPj4NCj4gPj4gV2hlbiBjb21waWxlLXRlc3Rpbmcg d2l0aCBmIE5PX0RNQT15Og0KPiA+Pg0KPiA+PiAgICAgZHJpdmVycy9uZXQvZXRoZXJuZXQvZnJl ZXNjYWxlL2ZtYW4vbWFjLmM6IEluIGZ1bmN0aW9uDQo+ID4+IOKAmGRwYWFfZXRoX2FkZF9kZXZp Y2XigJk6DQo+ID4+ICAgICBkcml2ZXJzL25ldC9ldGhlcm5ldC9mcmVlc2NhbGUvZm1hbi9tYWMu Yzo2MjY6IGVycm9yOiBpbXBsaWNpdA0KPiA+PiBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbiDigJhz ZXRfZG1hX29wc+KAmQ0KPiA+Pg0KPiA+PiBSZXZlcnRpbmcgY29tbWl0IDU1NjdlOTg5MTk4YjVh OGQgZml4ZXMgdGhpcyByZWdyZXNzaW9uIGluIHY0LjEyLXJjNy4NCj4gPj4NCj4gPj4gV2h5IGlz IHRoaXMgY2hhbmdlIG5lZWRlZD8NCj4gPj4gVGhlcmUncyBubyBzaW5nbGUgb3RoZXIgY2FsbCB0 byB0aGUgRE1BIEFQSSBpbiB0aGlzIGZpbGU/DQo+ID4NCj4gPiBXZSdyZSBzZXR0aW5nIGhlcmUg dGhlIGRtYV9vcHMgdGhhdCBhcmUgbGF0ZXIgdXNlZCBpbiB0aGUgb3RoZXINCj4gZHJpdmVyL3Bh dGNoLg0KPiA+IFRoZSBwcm9ibGVtIGlzIHdlIG5vdyBkZXBlbmQgdXBvbiBETUEgYnV0IGRvIG5v dCBleHBsaWNpdGx5IGRlY2xhcmUgaXQ6DQo+ID4NCj4gPiA8PENvZGUgdGhhdCBkZXBlbmRzIG9u IHRoZSBkbWEtbWFwcGluZyBBUEkgbmVlZHMgdG8gc2V0ICdkZXBlbmRzIG9uDQo+IEhBU19ETUEn DQo+ID4gaW4gaXRzIEtjb25maWc+Pg0KPiANCj4gU3VyZS4gQnV0IG9ubHkgaWYgdGhlIGRyaXZl ciByZWFsbHkgdXNlcyBETUEuDQo+IEkgY2FuIHN0aWNrIGEgc2V0X2RtYV9vcHMoKSBjYWxsIGlu IHdoYXRldmVyIGRyaXZlciwgYnV0IHRoYXQgZG9lc24ndA0KPiBtZWFuIGl0IHdpbGwNCj4gc3Vk ZGVubHkgdXNlIERNQS4NCj4gV2h5IGRvZXMgdGhlIEZNYW4gZHJpdmVyIHN1ZGRlbmx5IGhhcyBh IGRlcGVuZGVuY3kgb24gRE1BLCBpZiBpdCBkb2Vzbid0DQo+IHVzZSBETUE/DQo+IA0KPiA+IEkn bGwgbmVlZCB0byBhZGQgdGhpcyB0byB0aGUgRk1hbiBkcml2ZXIgS2NvbmZpZy4NCj4gDQo+IFdo eSBkb2VzIHRoZSBGTWFuIGRyaXZlciBuZWVkIHRoaXM/DQo+IFdoeSBjYW4ndCBoaXMgY2FsbCBi ZSBkb25lIGluIHRoZSBkcml2ZXIgdGhhdCB1c2VzIHRoZSBETUEgQVBJTz8NCg0KVGhlIERQQUEg RXRoZXJuZXQgZHJpdmVyIG1ha2VzIHVzZSBvZiBETUEgb3BzLiBJdCB1c2VkIHRvIGdldCB0aGVt IGZyb20NCmFuIEFQSSBjYWxsIChhcmNoX3NldHVwX2RtYV9vcHMpIHRoYXQgd2FzIG5vdCBleHBv cnRlZC4gVGhlIERQQUEgRXRoZXJuZXQNCnRoYXQgbWFrZXMgdXNlIG9mIHRoZSBGTWFuIGRldmlj ZXMgZG9lcyBub3QgZ2V0IHRoZSBkbWFfb3BzIGFzIGl0IGRvZXMgbm90DQpwcm9iZSBuZWl0aGVy IGFzIGFuIE9GIHBsYXRmb3JtIGRldmljZSBub3IgdGhvcm91Z2ggQUNQSS4gSXQgcHJvYmVzIGFz IGENCnBsYXRmb3JtIGRldmljZSBiYXNlZCBvbiBpbmZvcm1hdGlvbiBwcmVwYXJlZCBieSB0aGUg Rk1hbiBkcml2ZXIuIFdoYXQgdGhlDQpGTWFuIGNoYW5nZSBbMV0gZG9lcyBpcyBzdXBwbGVtZW50 IHRoZSBpbmZvcm1hdGlvbiBzaGFyZWQgd2l0aCB0aGUgRXRoZXJuZXQNCmRyaXZlciB3aXRoIHRo ZSBkbWFfb3BzIHRoYXQgdGhlIEZNYW4gZHJpdmVyIGdldHMgZHVyaW5nIE9GIHByb2JpbmcuIFRo ZXJlDQphcmUgbm8gc2NlbmFyaW9zIG9uZSBjYW4gdXNlIHRoZSBEUEFBIGRyaXZlcnMgd2l0aCBO T19ETUEsIGFzIGZhciBhcyBJIGtub3cuDQoNCkZvciBnZW5lcmFsIGluZm8gb24gdGhlIERQQUEg ZHJpdmVycyBwbGVhc2UgcmVmZXIgdG8gdGhlIGRvY3VtZW50YXRpb24NCmZvdW5kIGluIERvY3Vt ZW50YXRpb24vbmV0d29ya2luZy9kcGFhLnR4dC4gRm9yIHRoZSBwcm9iaW5nIG9mIHRoZSBFdGhl cm5ldA0KZHJpdmVyIHNlZSBjaGFuZ2UgWzJdIGFuZCBkcGFhX2V0aF9hZGRfZGV2aWNlKCkgaW4g ZnNsL2ZtYW4sIGRwYWFfZXRoX3Byb2JlKCkNCmluIGRwYWFfZXRoLg0KIA0KWzFdIDU1NjdlOTg5 MTk4YjVhOGQgZnNsL2ZtYW46IHByb3BhZ2F0ZSBkbWFfb3BzDQpbMl0gZmI1MjcyOGE5Mjk0ZDk3 ZCBkcGFhX2V0aDogcmV1c2UgdGhlIGRtYV9vcHMgcHJvdmlkZWQgYnkgdGhlIEZNYW4gTUFDIGRl dmljZQ0KDQo+IEdye29ldGplLGVldGluZ31zLA0KPiANCj4gICAgICAgICAgICAgICAgICAgICAg ICAgR2VlcnQNCj4gDQo+IC0tDQo+IEdlZXJ0IFV5dHRlcmhvZXZlbiAtLSBUaGVyZSdzIGxvdHMg b2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgtDQo+IG02OGsub3JnDQo+IA0KPiBJ biBwZXJzb25hbCBjb252ZXJzYXRpb25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwgSSBjYWxsIG15 c2VsZiBhIGhhY2tlci4NCj4gQnV0DQo+IHdoZW4gSSdtIHRhbGtpbmcgdG8gam91cm5hbGlzdHMg SSBqdXN0IHNheSAicHJvZ3JhbW1lciIgb3Igc29tZXRoaW5nIGxpa2UNCj4gdGhhdC4NCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51cyBUb3J2YWxkcw0KDQpUaGFua3Ms DQpNYWRhbGluDQo= ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] dpaa_eth: reuse the dma_ops provided by the FMan MAC device 2017-06-19 15:04 [PATCH 0/2] fix loadable module for DPAA Ethernet Madalin Bucur 2017-06-19 15:04 ` [PATCH 1/2] fsl/fman: propagate dma_ops Madalin Bucur @ 2017-06-19 15:04 ` Madalin Bucur 2017-06-20 17:47 ` [PATCH 0/2] fix loadable module for DPAA Ethernet David Miller 2 siblings, 0 replies; 8+ messages in thread From: Madalin Bucur @ 2017-06-19 15:04 UTC (permalink / raw) To: netdev, davem; +Cc: linuxppc-dev, linux-kernel, Madalin Bucur Remove the use of arch_setup_dma_ops() that was not exported and was breaking loadable module compilation. Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 9a520e4..290ad05 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2647,7 +2647,7 @@ static int dpaa_eth_probe(struct platform_device *pdev) priv->buf_layout[TX].priv_data_size = DPAA_TX_PRIV_DATA_SIZE; /* Tx */ /* device used for DMA mapping */ - arch_setup_dma_ops(dev, 0, 0, NULL, false); + set_dma_ops(dev, get_dma_ops(&pdev->dev)); err = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(40)); if (err) { dev_err(dev, "dma_coerce_mask_and_coherent() failed\n"); -- 2.1.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] fix loadable module for DPAA Ethernet 2017-06-19 15:04 [PATCH 0/2] fix loadable module for DPAA Ethernet Madalin Bucur 2017-06-19 15:04 ` [PATCH 1/2] fsl/fman: propagate dma_ops Madalin Bucur 2017-06-19 15:04 ` [PATCH 2/2] dpaa_eth: reuse the dma_ops provided by the FMan MAC device Madalin Bucur @ 2017-06-20 17:47 ` David Miller 2 siblings, 0 replies; 8+ messages in thread From: David Miller @ 2017-06-20 17:47 UTC (permalink / raw) To: madalin.bucur; +Cc: netdev, linuxppc-dev, linux-kernel From: Madalin Bucur <madalin.bucur@nxp.com> Date: Mon, 19 Jun 2017 18:04:15 +0300 > The DPAA Ethernet makes use of a symbol that is not exported. > Address the issue by propagating the dma_ops rather than calling > arch_setup_dma_ops(). Series applied, thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-06-27 6:49 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-06-19 15:04 [PATCH 0/2] fix loadable module for DPAA Ethernet Madalin Bucur 2017-06-19 15:04 ` [PATCH 1/2] fsl/fman: propagate dma_ops Madalin Bucur 2017-06-26 7:48 ` Geert Uytterhoeven 2017-06-26 14:55 ` Madalin-cristian Bucur 2017-06-26 16:24 ` Geert Uytterhoeven 2017-06-27 6:49 ` Madalin-cristian Bucur 2017-06-19 15:04 ` [PATCH 2/2] dpaa_eth: reuse the dma_ops provided by the FMan MAC device Madalin Bucur 2017-06-20 17:47 ` [PATCH 0/2] fix loadable module for DPAA Ethernet David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).