From: Nicholas Piggin <npiggin@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] powerpc/64s: Use BRANCH_TO_COMMON() for slb_miss_realmode
Date: Tue, 20 Jun 2017 22:54:18 +1000 [thread overview]
Message-ID: <20170620225418.73d862b8@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <1497962097-9402-1-git-send-email-mpe@ellerman.id.au>
On Tue, 20 Jun 2017 22:34:55 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:
> All the callers of slb_miss_realmode currently open code the #ifndef
> CONFIG_RELOCATABLE check and the branch via CTR in the RELOCATABLE case.
> We have a macro to do this, BRANCH_TO_COMMON(), so use it.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
These 3 all look good to me.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
next prev parent reply other threads:[~2017-06-20 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 12:34 [PATCH 1/3] powerpc/64s: Use BRANCH_TO_COMMON() for slb_miss_realmode Michael Ellerman
2017-06-20 12:34 ` [PATCH 2/3] powerpc/64s: Rename slb_miss_realmode() to slb_miss_common() Michael Ellerman
2017-06-20 12:34 ` [PATCH 3/3] powerpc/64s: Rename slb_allocate_realmode() to slb_allocate() Michael Ellerman
2017-06-20 12:54 ` Nicholas Piggin [this message]
2017-06-22 13:12 ` [1/3] powerpc/64s: Use BRANCH_TO_COMMON() for slb_miss_realmode Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620225418.73d862b8@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).